Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copy .ttf files during build #11219

Closed

Conversation

XiSenao
Copy link

@XiSenao XiSenao commented Dec 7, 2023

fixes #11220

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Dec 7, 2023

🦋 Changeset detected

Latest commit: 936296b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-cloudflare Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann
Copy link
Member

Assuming this is necessary, I expect other adapters would need the same fix. We should fix them all together so that we don't leave some behind

@XiSenao
Copy link
Author

XiSenao commented Dec 8, 2023

Assuming this is necessary, I expect other adapters would need the same fix. We should fix them all together so that we don't leave some behind

This may require a little modification, and it seems that the way vite calls esbuild in the pre-build stage can be used as a reference.

https://github.com/vitejs/vite/blob/main/packages/vite/src/node/optimizer/esbuildDepPlugin.ts#L131-L285

@benmccann benmccann requested a review from eltigerchino May 31, 2024 13:01
@eltigerchino
Copy link
Member

eltigerchino commented May 31, 2024

eltigerchino/svelte-og-image#1 (comment) for context. I think we'd need to change the esbuild settings to copy .ttf files for cloudflare, cloudflare workers, vercel, and netlify (am I missing any other adapters?).

We could also configure it to use the copy loader for all the same asset types that Vite recognises but I'm only certain that the font asset types are included in most packages.

I'm also in favour of removing the default filename hashing behaviour (or providing a way to turn it off?) but maybe that's a separate issue because I'm not sure if that would disrupt build caches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No loader is configured for ".ttf" files.
3 participants