Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: document head null error #233

Closed

Conversation

leafOfTree
Copy link

@leafOfTree leafOfTree commented Sep 24, 2024

This is to fix #232

Add check for document.head. If it's null, call appendChild on the event DOMContentLoaded

@ignatiusmb
Copy link
Member

Thanks for the PR! I've added some context in #232 (comment) but it seems like we'll need to find another fix as this would effectively invalidate the injectImmediately setting. Perhaps we could try removing the setting altogether, but I'll need to check what behaviors was prevented by enabling it in the first place

@ignatiusmb
Copy link
Member

Thanks for this, #238 has been merged and should fix the issue

@ignatiusmb ignatiusmb closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on macos Chrome - Uncaught TypeError: Cannot read properties of null (reading 'appendChild')
2 participants