Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add outro option to unmount #14540

Merged
merged 10 commits into from
Dec 14, 2024
Merged

feat: add outro option to unmount #14540

merged 10 commits into from
Dec 14, 2024

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Dec 4, 2024

Just an experiment. Supersedes #9056. If you call unmount(component, { outro: true }) then the component's outro transitions will play before the DOM is removed. (You can't 'remount' the component during this time, unmounting is a one-way street.) unmount now returns a Promise.

Demo here.

Notes:

  • in the demo the fly transition needs the global modifier in order for the intro to work (but only in the playground, works fine in local testing). That seems odd?

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Dec 4, 2024

🦋 Changeset detected

Latest commit: 24683c4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member Author

preview: https://svelte-dev-git-preview-svelte-14540-svelte.vercel.app/

this is an automated message

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Playground

pnpm add https://pkg.pr.new/svelte@14540

@Serator
Copy link

Serator commented Dec 4, 2024

You can't 'remount' the component during this time, unmounting is a one-way street.

@Rich-Harris Is there any chance of changing this behavior? In other words, is it possible to make both animations work synchronously in this example?

@Rich-Harris
Copy link
Member Author

No, that would make things vastly more complicated for no real reason

@Rich-Harris Rich-Harris marked this pull request as ready for review December 14, 2024 13:48
@Rich-Harris Rich-Harris merged commit b0e3c5b into main Dec 14, 2024
11 checks passed
@Rich-Harris Rich-Harris deleted the unmount-with-outro branch December 14, 2024 14:05
@github-actions github-actions bot mentioned this pull request Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants