-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add outro option to unmount #14540
Conversation
🦋 Changeset detectedLatest commit: 24683c4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
preview: https://svelte-dev-git-preview-svelte-14540-svelte.vercel.app/ this is an automated message |
|
@Rich-Harris Is there any chance of changing this behavior? In other words, is it possible to make both animations work synchronously in this example? |
No, that would make things vastly more complicated for no real reason |
Just an experiment. Supersedes #9056. If you call
unmount(component, { outro: true })
then the component's outro transitions will play before the DOM is removed. (You can't 'remount' the component during this time, unmounting is a one-way street.)unmount
now returns aPromise
.Demo here.
Notes:
fly
transition needs theglobal
modifier in order for the intro to work (but only in the playground, works fine in local testing). That seems odd?Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint