fix: improve array mutation validation warnings #14729
Conversation
🦋 Changeset detectedLatest commit: 45875e9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
| @@ -16,7 +23,7 @@ export function init_array_prototype_warnings() { | |||
| array_prototype.indexOf = function (item, from_index) { | |||
| const index = indexOf.call(this, item, from_index); | |||
|
|
|||
| if (index === -1) { | |||
| if (index === -1 && is_object(item)) { | |||
There was a problem hiding this comment.
What I don't quite understand is why the proxied version would give a different result - is it not updated yet to the latest value?
There was a problem hiding this comment.
We don't modify the original object on mutations to the proxied object, so here the proxied version is [] and the original object is [1], so it triggers the warning because it first checks if the proxied array has it, then checks if the original array has it.
|
This doesn't seem right at all. The issue is that we're comparing the proxied array with its target, when we should be comparing the proxied items with their targets. Notice how in this repro the warnings still occur after you've cleared the array. Opened #14738 |
Closes #14705.