You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should fix the bug where a traced dependency that was mutated as part of the same effect incorrectly gets marked as not changed. I haven't had time to extensively test it though so leaving as a draft.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
@webJose this fixes my minimal reproduction but for some reason it doesn't fix your code...could you try to slim down the example now that you've identified the culprit of the last rerun? Your algorithm is still confusing for me but I want to try to understand what's going on there (I also had this problem in my fix in local)
@paoloricciuti Hello! Thank you for your interest in helping me out with my disgraces. 😄 Currently working on a production deployment. I'll try to dig stuff up with my code and see what I can find.
@paoloricciuti Hello! Thank you for your interest in helping me out with my disgraces. 😄 Currently working on a production deployment. I'll try to dig stuff up with my code and see what I can find.
I was digging a bit before, I think the code @trueadm added here has a slight "bug" which is what is causing the inconsistency with your code...basically he's increasing the version of the dependencies if it doesn't match with the previous dependency. What I think is happening is that the code introduce a new dependency and also increase the value so it should show up blue but it's not...but I need to investigate further
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix the bug where a traced dependency that was mutated as part of the same effect incorrectly gets marked as not changed. I haven't had time to extensively test it though so leaving as a draft.
Fixes #14794