-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(14815): warn when an invalid <select multiple> value is given #14816
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 6564b41 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
preview: https://svelte-dev-git-preview-svelte-14816-svelte.vercel.app/ this is an automated message |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall is good...however we recently switched to let TS handle this kind of typing issues so maybe we can just prevent the fail without throwing the warning.
In this case it's a bit different tho because this will be a much more descriptive error... I'll let some other maintainer with more experience decide on this 😁
*/ | ||
function select_options(select, value) { | ||
for (var option of select.options) { | ||
// @ts-ignore | ||
option.selected = ~value.indexOf(get_option_value(option)); | ||
option.selected = value.includes(get_option_value(option)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure this has performance implications...I don't know why it was written this way tho
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want better (theoretical) performance, we should use neither .indexOf
nor .includes
(code will be O(select.options.length * value.length)
) but rewrite it as
const values = new Set(value);
for (var option of select.options) {
option.selected = values.has(get_option_value(option));
}
which is now O(select.options.length + value.length)
We'll see what perf addicts say of this 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* @param {HTMLSelectElement} select | ||
* @param {V} value | ||
* @param {unknown[]} value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't make much sense to have a templated function that does not use nor restrict its type parameter, it can be replaced with any
. Asking for unknown[]
makes it more type-safe, // @ts-ignore
is no longer required.
Thanks for the review @paoloricciuti! For consistency, I'd say that |
Before submitting the PR, please make sure you do the following
Emit a warning instead of crashing the runtime when an invalid value is provided
Closes #14815
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint