Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Don't use "lame" in documentation #14833

Closed
wants to merge 2 commits into from

Conversation

danieldiekmeier
Copy link

@danieldiekmeier danieldiekmeier commented Dec 25, 2024

I noticed that the docs for the new class features use cool/lame as an example. The usage of the word "lame" feels a bit unnecessary in this case and some people (including me) consider it ableist. For example, Merriam-Webster say:

Lame is no longer applied to people in medical contexts, and the disparaging uses, as in "a lame excuse," "he's so lame," "a lame party," and "lame jokes," are occasionally considered to be offensive as well.

(via https://www.merriam-webster.com/dictionary/lame)

My suggestion is to replace the wanted contrast with cool/boring and be done with it. I also quickly checked for other ableist words in examples but couldn't find any. (There were two "dumb"s in code comments, and I changed them as well, but they are not user-facing.)

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Dec 25, 2024

⚠️ No Changeset found

Latest commit: a3ce4be

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Conduitry
Copy link
Member

In a tremendous coincidence, "lame" and "dumb" are two of the words that this PR brings to mind.

@danieldiekmeier
Copy link
Author

Oh, okay. Sorry.

@danieldiekmeier
Copy link
Author

I’m really surprised by this comment, this is not what I expected. It’s okay that you don’t like the PR, but I feel this comment does not meet the code of conduct at all. Sorry for wasting your time on this, I‘m definitely sorry I wasted my own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants