Big PR 1/7: UX basics part 1 #170
Conversation
…) and record them to the undo history
…iables for long edit_mode expressions, add grid_is_square() helper
… (only normal square puzzles for now)
…u mode, and make shift-arrow work too
… certain submodes for now)
…mode, and make the logic less restrictive on what types of cells this works for
…ht want to clear the selection in some cases but for now having more cells selected when changing modes etc is much better than it clearing all the time
… clicks on a selected cell and drags
|
Thank you. I will start the review soon after I settle down from my traveling. Can you please change the merging branch to dev branch instead of master. @zwegner |
|
Update: Just started catching up with all PRs. Reviewing this one now. :) |
| @@ -8659,26 +8651,6 @@ class Puzzle { | |||
| } | |||
| } | |||
|
|
|||
| mouse_numberS(x, y, num, submode) { | |||
There was a problem hiding this comment.
Is there a reason, you removed this piece of code? The only purpose of this code was to improve the experience with certain types of puzzles that involve both big digits and corner digits as part of solution. E.g. Tight Fit Sudoku
| @@ -893,15 +898,6 @@ onload = function() { | |||
| } | |||
| } | |||
|
|
|||
| // resetting the type for starbattle composite mode | |||
There was a problem hiding this comment.
Is there a reason for removing this segment?
I am unable to recollect the exact reason why I needed this but something around improving the composite mode behavior especially on mobiles/ipads.
|
@zwegner Thank you for this PR. I think for the most part it looks great. There are couple of review comments above and a couple of other things that I mention it below:
|
Hello Swaroop! I've been organizing the big amount of changes I have to be grouped into smaller logical chunks, and here's the first: starting off with some refactoring that is used in many places throughout all my changes, followed by a bunch of small interface tweaks to improve the user experience, mostly dealing with selection behavior.
Happy to answer any questions you might have about the changes. I've also made more branches for my intended future PRs after this one if you're curious to look ahead.