Fix undefined behavior problem when using list_foreach_entry #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This upstream list.h offsetof implementation rely on undefined behavior implementation. Using __builtin_offsetof to fix this problem.
swine
pushed a commit
that referenced
this pull request
Aug 10, 2023
On aarch64, only the ASSERT_RTNL macro is affected by source line number
changes (WARN, BUG, etc. no longer embed line numbers in the instruction
stream.) A small test function that invokes the macro for a line change
from 42 to 43:
0000000000000000 <test_assert_rtnl>:
0: d503245f bti c
4: d503201f nop
8: d503201f nop
c: d503233f paciasp
10: a9bf7bfd stp x29, x30, [sp, #-16]!
14: 910003fd mov x29, sp
18: 94000000 bl 0 <rtnl_is_locked>
18: R_AARCH64_CALL26 rtnl_is_locked
1c: 34000080 cbz w0, 2c <test_assert_rtnl+0x2c>
20: a8c17bfd ldp x29, x30, [sp], dynup#16
24: d50323bf autiasp
28: d65f03c0 ret
2c: 90000000 adrp x0, 0 <test_assert_rtnl>
2c: R_AARCH64_ADR_PREL_PG_HI21 .data.once
30: 39400001 ldrb w1, [x0]
30: R_AARCH64_LDST8_ABS_LO12_NC .data.once
34: 35ffff61 cbnz w1, 20 <test_assert_rtnl+0x20>
38: 52800022 mov w2, #0x1 // #1
3c: 90000001 adrp x1, 0 <test_assert_rtnl>
3c: R_AARCH64_ADR_PREL_PG_HI21 .rodata.str1.8+0x8
40: 39000002 strb w2, [x0]
40: R_AARCH64_LDST8_ABS_LO12_NC .data.once
44: 91000021 add x1, x1, #0x0
44: R_AARCH64_ADD_ABS_LO12_NC .rodata.str1.8+0x8
- 48: 52800542 mov w2, #0x2a // dynup#42
+ 48: 52800562 mov w2, #0x2b // dynup#43
4c: 90000000 adrp x0, 0 <test_assert_rtnl>
4c: R_AARCH64_ADR_PREL_PG_HI21 .rodata.str1.8+0x20
50: 91000000 add x0, x0, #0x0
50: R_AARCH64_ADD_ABS_LO12_NC .rodata.str1.8+0x20
54: 94000000 bl 0 <__warn_printk>
54: R_AARCH64_CALL26 __warn_printk
58: d4210000 brk #0x800
5c: 17fffff1 b 20 <test_assert_rtnl+0x20>
Create an implementation of kpatch_line_macro_change_only() for aarch64
modeled after the other architectures. Only look for relocations to
__warn_printk that ASSERT_RTNL invokes.
Based-on-s390x-code-by: C. Erastus Toe <[email protected]>
Signed-off-by: Joe Lawrence <[email protected]>
swine
pushed a commit
that referenced
this pull request
Nov 13, 2023
On aarch64, only the ASSERT_RTNL macro is affected by source line number
changes (WARN, BUG, etc. no longer embed line numbers in the instruction
stream.) A small test function that invokes the macro for a line change
from 42 to 43:
0000000000000000 <test_assert_rtnl>:
0: d503245f bti c
4: d503201f nop
8: d503201f nop
c: d503233f paciasp
10: a9bf7bfd stp x29, x30, [sp, #-16]!
14: 910003fd mov x29, sp
18: 94000000 bl 0 <rtnl_is_locked>
18: R_AARCH64_CALL26 rtnl_is_locked
1c: 34000080 cbz w0, 2c <test_assert_rtnl+0x2c>
20: a8c17bfd ldp x29, x30, [sp], dynup#16
24: d50323bf autiasp
28: d65f03c0 ret
2c: 90000000 adrp x0, 0 <test_assert_rtnl>
2c: R_AARCH64_ADR_PREL_PG_HI21 .data.once
30: 39400001 ldrb w1, [x0]
30: R_AARCH64_LDST8_ABS_LO12_NC .data.once
34: 35ffff61 cbnz w1, 20 <test_assert_rtnl+0x20>
38: 52800022 mov w2, #0x1 // #1
3c: 90000001 adrp x1, 0 <test_assert_rtnl>
3c: R_AARCH64_ADR_PREL_PG_HI21 .rodata.str1.8+0x8
40: 39000002 strb w2, [x0]
40: R_AARCH64_LDST8_ABS_LO12_NC .data.once
44: 91000021 add x1, x1, #0x0
44: R_AARCH64_ADD_ABS_LO12_NC .rodata.str1.8+0x8
- 48: 52800542 mov w2, #0x2a // dynup#42
+ 48: 52800562 mov w2, #0x2b // dynup#43
4c: 90000000 adrp x0, 0 <test_assert_rtnl>
4c: R_AARCH64_ADR_PREL_PG_HI21 .rodata.str1.8+0x20
50: 91000000 add x0, x0, #0x0
50: R_AARCH64_ADD_ABS_LO12_NC .rodata.str1.8+0x20
54: 94000000 bl 0 <__warn_printk>
54: R_AARCH64_CALL26 __warn_printk
58: d4210000 brk #0x800
5c: 17fffff1 b 20 <test_assert_rtnl+0x20>
Create an implementation of kpatch_line_macro_change_only() for aarch64
modeled after the other architectures. Only look for relocations to
__warn_printk that ASSERT_RTNL invokes.
Based-on-s390x-code-by: C. Erastus Toe <[email protected]>
Signed-off-by: Joe Lawrence <[email protected]>
swine
pushed a commit
that referenced
this pull request
May 31, 2024
On aarch64, only the ASSERT_RTNL macro is affected by source line number
changes (WARN, BUG, etc. no longer embed line numbers in the instruction
stream.) A small test function that invokes the macro for a line change
from 42 to 43:
0000000000000000 <test_assert_rtnl>:
0: d503245f bti c
4: d503201f nop
8: d503201f nop
c: d503233f paciasp
10: a9bf7bfd stp x29, x30, [sp, #-16]!
14: 910003fd mov x29, sp
18: 94000000 bl 0 <rtnl_is_locked>
18: R_AARCH64_CALL26 rtnl_is_locked
1c: 34000080 cbz w0, 2c <test_assert_rtnl+0x2c>
20: a8c17bfd ldp x29, x30, [sp], dynup#16
24: d50323bf autiasp
28: d65f03c0 ret
2c: 90000000 adrp x0, 0 <test_assert_rtnl>
2c: R_AARCH64_ADR_PREL_PG_HI21 .data.once
30: 39400001 ldrb w1, [x0]
30: R_AARCH64_LDST8_ABS_LO12_NC .data.once
34: 35ffff61 cbnz w1, 20 <test_assert_rtnl+0x20>
38: 52800022 mov w2, #0x1 // #1
3c: 90000001 adrp x1, 0 <test_assert_rtnl>
3c: R_AARCH64_ADR_PREL_PG_HI21 .rodata.str1.8+0x8
40: 39000002 strb w2, [x0]
40: R_AARCH64_LDST8_ABS_LO12_NC .data.once
44: 91000021 add x1, x1, #0x0
44: R_AARCH64_ADD_ABS_LO12_NC .rodata.str1.8+0x8
- 48: 52800542 mov w2, #0x2a // dynup#42
+ 48: 52800562 mov w2, #0x2b // dynup#43
4c: 90000000 adrp x0, 0 <test_assert_rtnl>
4c: R_AARCH64_ADR_PREL_PG_HI21 .rodata.str1.8+0x20
50: 91000000 add x0, x0, #0x0
50: R_AARCH64_ADD_ABS_LO12_NC .rodata.str1.8+0x20
54: 94000000 bl 0 <__warn_printk>
54: R_AARCH64_CALL26 __warn_printk
58: d4210000 brk #0x800
5c: 17fffff1 b 20 <test_assert_rtnl+0x20>
Create an implementation of kpatch_line_macro_change_only() for aarch64
modeled after the other architectures. Only look for relocations to
__warn_printk that ASSERT_RTNL invokes.
Based-on-s390x-code-by: C. Erastus Toe <[email protected]>
Signed-off-by: Joe Lawrence <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upstream list.h offsetof implementation rely on undefined behavior implementation. Using __builtin_offsetof to fix this problem.