chore: remove global styles #3554

bashirkarimi · 2024-09-17T12:55:52Z

Removed:

root
reboot
bootstrap/type
bootstrap/license

A separate ticket is created to fix the broken styles: https://github.com/orgs/swisspost/projects/3/views/12?pane=issue&itemId=80363901

This reverts commit 1334b7a.

changeset-bot · 2024-09-17T12:55:56Z

🦋 Changeset detected

Latest commit: c8bd686

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages

Name	Type
@swisspost/design-system-styles	Patch
@swisspost/design-system-components-angular-workspace	Patch
@swisspost/design-system-components	Patch
@swisspost/design-system-demo	Patch
@swisspost/design-system-documentation	Patch
@swisspost/internet-header	Patch
@swisspost/design-system-intranet-header-workspace	Patch
@swisspost/design-system-nextjs-integration	Patch
@swisspost/design-system-styles-primeng-workspace	Patch
@swisspost/design-system-intranet-header	Patch
@swisspost/design-system-styles-primeng	Patch
@swisspost/design-system-components-react	Patch
@swisspost/design-system-components-angular	Patch
@swisspost/design-system-intranet-header-showcase	Patch
@swisspost/design-system-tokens	Patch
@swisspost/design-system-icons	Patch
@swisspost/design-system-migrations	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

swisspost-bot · 2024-09-17T12:56:08Z

Related Previews

oliverschuerch · 2024-09-19T08:48:07Z

packages/documentation/.storybook/styles/components/typo.scss

@@ -24,7 +24,7 @@ body {
    }

    .docs-story > :first-child {
-      font-family: var(--bs-body-font-family);
+      font-family: var(--post-core-font-family-frutiger);


We should never use the core tokens somewhere!

Please use the --post-body-font-family here.
Maybe also use the tokens.get() function together with the $post-body map.

The value of --post-body-font-family is Swiss Post Sans v005. Should we use Swiss Post Sans v005 or Frutiger Neue For Post?

I have implemented your suggestion and will check the correct font-family in the https://github.com/orgs/swisspost/projects/3/views/17?pane=issue&itemId=78602494

Let's use the token --post-body-font-family as is and rename the font name in the @font-face definition in the font.scss file to match the new name.

The fonts.scss file should be adapted like this:

@forward './../variables/options'; @use './../variables/options'; @font-face { font-display: swap; font-family: 'Swiss Post Sans v005'; font-weight: 900; src: url('#{options.$font-base-path}/FrutigerNeueforPostW05-Blk.woff2') format('woff2'), url('#{options.$font-base-path}/FrutigerNeueforPostW05-Blk.woff') format('woff'); } @font-face { font-display: swap; font-family: 'Swiss Post Sans v005'; font-weight: 900; font-style: italic; src: url('#{options.$font-base-path}/FrutigerNeueforPostW05-BlkIt.woff2') format('woff2'), url('#{options.$font-base-path}/FrutigerNeueforPostW05-BlkIt.woff') format('woff'); } @font-face { font-display: swap; font-family: 'Swiss Post Sans v005'; font-weight: 700; src: url('#{options.$font-base-path}/FrutigerNeueforPostW05-Bold.woff2') format('woff2'), url('#{options.$font-base-path}/FrutigerNeueforPostW05-Bold.woff') format('woff'); } @font-face { font-display: swap; font-family: 'Swiss Post Sans v005'; font-weight: 700; font-style: italic; src: url('#{options.$font-base-path}/FrutigerNeueforPostW05-BdIt.woff2') format('woff2'), url('#{options.$font-base-path}/FrutigerNeueforPostW05-BdIt.woff') format('woff'); } @font-face { font-display: swap; font-family: 'Swiss Post Sans v005'; font-weight: 400; src: url('#{options.$font-base-path}/FrutigerNeueforPostW05-Rg.woff2') format('woff2'), url('#{options.$font-base-path}/FrutigerNeueforPostW05-Rg.woff') format('woff'); } @font-face { font-display: swap; font-family: 'Swiss Post Sans v005'; font-weight: 400; font-style: italic; src: url('#{options.$font-base-path}/FrutigerNeueforPostW05-It.woff2') format('woff2'), url('#{options.$font-base-path}/FrutigerNeueforPostW05-It.woff') format('woff'); }

The fonts are renamed.

packages/documentation/.storybook/styles/components/typo.scss

packages/styles/src/themes/bootstrap/_forms.scss

packages/styles/src/components/type.scss

packages/styles/src/components/reboot.scss

packages/styles/src/components/base.scss

oliverschuerch · 2024-09-19T13:54:00Z

packages/styles/src/elements/body.scss

+// fixes for color in buttons
 @use './../mixins/color' as mx-color;
-@use './../variables/animation';
 @use './../variables/color';

 body {
-  @include type.font-smoothing();
  @include mx-color.colored-background(color.$white);
 }


I would say we should remove this temporary button fix now, so we don't have to remember it later (when we implement the new button styles).

It is removed.

oliverschuerch · 2024-09-19T14:03:31Z

packages/documentation/.storybook/styles/components/typo.scss

@@ -24,7 +24,7 @@ body {
    }

    .docs-story > :first-child {
-      font-family: var(--bs-body-font-family);
+      font-family: var(--post-core-font-family-frutiger);


Let's use the token --post-body-font-family as is and rename the font name in the @font-face definition in the font.scss file to match the new name.

oliverschuerch · 2024-09-19T14:20:06Z

packages/documentation/.storybook/styles/components/typo.scss

@@ -24,7 +24,7 @@ body {
    }

    .docs-story > :first-child {
-      font-family: var(--bs-body-font-family);
+      font-family: var(--post-core-font-family-frutiger);


The fonts.scss file should be adapted like this:

@forward './../variables/options'; @use './../variables/options'; @font-face { font-display: swap; font-family: 'Swiss Post Sans v005'; font-weight: 900; src: url('#{options.$font-base-path}/FrutigerNeueforPostW05-Blk.woff2') format('woff2'), url('#{options.$font-base-path}/FrutigerNeueforPostW05-Blk.woff') format('woff'); } @font-face { font-display: swap; font-family: 'Swiss Post Sans v005'; font-weight: 900; font-style: italic; src: url('#{options.$font-base-path}/FrutigerNeueforPostW05-BlkIt.woff2') format('woff2'), url('#{options.$font-base-path}/FrutigerNeueforPostW05-BlkIt.woff') format('woff'); } @font-face { font-display: swap; font-family: 'Swiss Post Sans v005'; font-weight: 700; src: url('#{options.$font-base-path}/FrutigerNeueforPostW05-Bold.woff2') format('woff2'), url('#{options.$font-base-path}/FrutigerNeueforPostW05-Bold.woff') format('woff'); } @font-face { font-display: swap; font-family: 'Swiss Post Sans v005'; font-weight: 700; font-style: italic; src: url('#{options.$font-base-path}/FrutigerNeueforPostW05-BdIt.woff2') format('woff2'), url('#{options.$font-base-path}/FrutigerNeueforPostW05-BdIt.woff') format('woff'); } @font-face { font-display: swap; font-family: 'Swiss Post Sans v005'; font-weight: 400; src: url('#{options.$font-base-path}/FrutigerNeueforPostW05-Rg.woff2') format('woff2'), url('#{options.$font-base-path}/FrutigerNeueforPostW05-Rg.woff') format('woff'); } @font-face { font-display: swap; font-family: 'Swiss Post Sans v005'; font-weight: 400; font-style: italic; src: url('#{options.$font-base-path}/FrutigerNeueforPostW05-It.woff2') format('woff2'), url('#{options.$font-base-path}/FrutigerNeueforPostW05-It.woff') format('woff'); }

sonarqubecloud · 2024-09-19T14:58:08Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@schaertim

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. ⚠️

⚠️

⚠️ `main` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `main`. ⚠️

⚠️

⚠️ # Releases ## @swisspost/[email protected] ### Major Changes - Made the heading-level property required for the accordion and removed it from the accordion-item docs. (by [@schaertim](https://github.com/schaertim) with [#3383](#3383)) ### Patch Changes - Fixed a bug in nested accordions where closing a child item unintentionally closed all parent accordion elements. (by [@schaertim](https://github.com/schaertim) with [#3427](#3427)) - Fixed an issue related to conflicting pointer and focus events hiding the tooltip unexpectedly in some situations. The tooltip now behaves as expected in this situation. (by [@alionazherdetska](https://github.com/alionazherdetska) with [#3592](#3592)) - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Major Changes - Removed the following placeholders: `%list-adjustment`, `%module-container`, `%default-module-spacer`, `%text-container`. (by [@leagrdv](https://github.com/leagrdv) with [#3623](#3623)) - Updated the margin, padding, and gap utility classes to use the pixel values (1, 2, ... , 112) instead of size names (hair, line, ..., bigger-giant). (by [@alizedebray](https://github.com/alizedebray) with [#3557](#3557)) ### Minor Changes - Added Text Highlighted component. (by [@bashirkarimi](https://github.com/bashirkarimi) with [#3586](#3586)) - Added lead text component for introductory paragraphs. (by [@bashirkarimi](https://github.com/bashirkarimi) with [#3575](#3575)) ### Patch Changes - styles: Added reset styles (by [@bashirkarimi](https://github.com/bashirkarimi) with [#3545](#3545)) - Removed global styles (by [@bashirkarimi](https://github.com/bashirkarimi) with [#3554](#3554)) - Updated the style of headings (h1-h6). (by [@bashirkarimi](https://github.com/bashirkarimi) with [#3534](#3534)) ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ## @swisspost/[email protected] ## @swisspost/[email protected] ### Major Changes - Made the heading-level property required for the accordion and removed it from the accordion-item docs. (by [@schaertim](https://github.com/schaertim) with [#3383](#3383)) ### Minor Changes - Added a toolbar for switching the theme, channel, and mode of all stories. (by [@alizedebray](https://github.com/alizedebray) with [#3528](#3528)) - Added documentation outlining the mission statement of the Design System. (by [@alionazherdetska](https://github.com/alionazherdetska) with [#3568](#3568)) - Added Text Highlighted component. (by [@bashirkarimi](https://github.com/bashirkarimi) with [#3586](#3586)) - Updated the margin, padding, and gap utility classes to use the pixel values (1, 2, ... , 112) instead of size names (hair, line, ..., bigger-giant). (by [@alizedebray](https://github.com/alizedebray) with [#3557](#3557)) - Added documentation for design principles. (by [@alionazherdetska](https://github.com/alionazherdetska) with [#3565](#3565)) - Added lead text component for introductory paragraphs. (by [@bashirkarimi](https://github.com/bashirkarimi) with [#3575](#3575)) ### Patch Changes - Updated the style of headings (h1-h6). (by [@bashirkarimi](https://github.com/bashirkarimi) with [#3534](#3534)) - Fixed typos in the Sass and HTML href paths. (by [@schaertim](https://github.com/schaertim) with [#3466](#3466)) - Updated dependencies: - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

karimim added 9 commits September 16, 2024 16:10

chore: remove bootstrap reboot and root files

c0539ca

chore: remove background color of root element

1f9930b

chore: remove reference of root and type

d6f6cfd

chore: remove transition

1334b7a

chore: remove bootstrap root

020eb26

Revert "chore: remove transition"

38b7b01

This reverts commit 1334b7a.

chore: remove bootstrap label style

c13f76b

chore: remove bootstrap licence reference

4b25667

chore: remove bootstrap licence

b3f3e65

bashirkarimi linked an issue Sep 17, 2024 that may be closed by this pull request

Remove global styles #3543

Closed

karimim added 2 commits September 17, 2024 15:01

feat: add changeset

b081a3c

style: refomat code

68108f0

bashirkarimi marked this pull request as ready for review September 17, 2024 13:09

bashirkarimi requested a review from a team as a code owner September 17, 2024 13:09

bashirkarimi requested review from gfellerph and oliverschuerch September 17, 2024 13:09

karimim and others added 3 commits September 17, 2024 15:52

fix: remove reboot test

8f90c1c

fix: set font-family to Post Frutiger font

0fbe279

Merge branch 'main' into 3543-remove-global-styles

c9f21d2

bashirkarimi marked this pull request as draft September 18, 2024 14:23

karimim and others added 4 commits September 18, 2024 16:24

fix: add colors to components and storybook

bcec2fe

fix: fixes the font name

c39b480

Merge branch 'main' into 3543-remove-global-styles

6b0311e

fix: add hover style for button

c9829a9

bashirkarimi marked this pull request as ready for review September 19, 2024 06:48

oliverschuerch requested changes Sep 19, 2024

View reviewed changes

karimim added 2 commits September 19, 2024 11:29

feat: add default style for table

2c32406

chore: move the base style to body

516030e

karimim added 8 commits September 19, 2024 11:56

chore: remove type style

0ae59be

chore: remove unused file

b908089

fix: set the correct font-family variable

461e036

fix: fixes typo

13e08fb

fix: remove unused references

3888240

chore: remove unused tests

dfd4a2e

fix: remove unused reference

0c958f9

fix: get body styles

9ea4521

oliverschuerch self-requested a review September 19, 2024 12:27

oliverschuerch requested changes Sep 19, 2024

View reviewed changes

karimim added 2 commits September 19, 2024 16:33

chore: rename fonts to align with css variable

04ae42e

chore: remove bootstrap color for body

a890de4

oliverschuerch approved these changes Sep 19, 2024

View reviewed changes

chore: add font 900 and remove font 300

c8bd686

bashirkarimi merged commit 4b1d587 into main Sep 19, 2024
11 of 12 checks passed

bashirkarimi deleted the 3543-remove-global-styles branch September 19, 2024 14:58

swisspost-bot mentioned this pull request Sep 20, 2024

chore(changesets): 🦋📦 publish packages (main) (next) #3551

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: remove global styles #3554

chore: remove global styles #3554

bashirkarimi commented Sep 17, 2024 •

edited

Loading

changeset-bot bot commented Sep 17, 2024 •

edited

Loading

swisspost-bot commented Sep 17, 2024 •

edited

Loading

oliverschuerch Sep 19, 2024

bashirkarimi Sep 19, 2024

bashirkarimi Sep 19, 2024

oliverschuerch Sep 19, 2024 •

edited

Loading

oliverschuerch Sep 19, 2024

bashirkarimi Sep 19, 2024

oliverschuerch Sep 19, 2024

bashirkarimi Sep 19, 2024

oliverschuerch Sep 19, 2024 •

edited

Loading

oliverschuerch Sep 19, 2024

sonarqubecloud bot commented Sep 19, 2024

chore: remove global styles #3554

chore: remove global styles #3554

Conversation

bashirkarimi commented Sep 17, 2024 • edited Loading

changeset-bot bot commented Sep 17, 2024 • edited Loading

🦋 Changeset detected

swisspost-bot commented Sep 17, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oliverschuerch Sep 19, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oliverschuerch Sep 19, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Sep 19, 2024

Quality Gate passed

bashirkarimi commented Sep 17, 2024 •

edited

Loading

changeset-bot bot commented Sep 17, 2024 •

edited

Loading

swisspost-bot commented Sep 17, 2024 •

edited

Loading

oliverschuerch Sep 19, 2024 •

edited

Loading

oliverschuerch Sep 19, 2024 •

edited

Loading