Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(components): update the post-menu to be usable inside other com… #4337

Merged
merged 2 commits into from
Dec 19, 2024
Merged

chore(components): update the post-menu to be usable inside other com… #4337

merged 2 commits into from
Dec 19, 2024

Conversation

alizedebray
Copy link
Contributor

…ponents

@alizedebray alizedebray requested a review from a team as a code owner December 18, 2024 15:54
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 18, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7a703ce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alizedebray alizedebray requested review from alionazherdetska and oliverschuerch and removed request for oliverschuerch December 18, 2024 15:55
@swisspost-bot
Copy link
Contributor

swisspost-bot commented Dec 18, 2024 •
edited
Loading

Related Previews

@alizedebray alizedebray mentioned this pull request Dec 18, 2024
Merged
oliverschuerch
oliverschuerch requested changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@oliverschuerch oliverschuerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure anymore, if we decided to add changesets for raw components to or not?

packages/components/src/utils/get-focusable-children.ts Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@alizedebray alizedebray merged commit 85297d3 into main Dec 19, 2024
10 checks passed
@alizedebray alizedebray deleted the update-post-menu branch December 19, 2024 14:55
alizedebray added a commit that referenced this pull request Dec 19, 2024
@alizedebray @leagrdv
fix(components): fix the language switch keyboard navigation (#4340)
f5054b1 
The changes to the post-menu are part of the PR #4337 that should be
merge before this one.

:information_source: **Only the commit
b899725
needs to be reviewed in this PR.**

---------

Co-authored-by: Lea <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverschuerch oliverschuerch oliverschuerch approved these changes

@alionazherdetska alionazherdetska Awaiting requested review from alionazherdetska

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alizedebray @swisspost-bot @oliverschuerch