code quality improvements on connection pool

CHANGELOG.md

@@ -15,6 +15,7 @@ Fixed:
 * Fix return value of method _\Swoole\Server\Admin::start()_. ([commit](https://github.com/swoole/library/commit/f211ae16cb3075b5977c52d7fd8f4896a8c51dc7))
 * Fix method _\Swoole\MultibyteStringObject::ipos()_. ([commit](https://github.com/swoole/library/commit/3a543c1dc5f116f3fbd96c69b83413193f050086))
 * Fix incorrect operator precedence used in method _\Swoole\Coroutine\Admin::start()_. ([commit](https://github.com/swoole/library/commit/49ed9a7b7ad1678a602310c50149f0e46ec0927a))
+* Fix issue swoole/library#164 : set_charset() should be called if DB connection succeeds.
 
 Changed:
 

phpstan.neon.dist

@@ -11,6 +11,5 @@ parameters:
     - '#Access to an undefined property Swoole\\Coroutine\\Http\\ClientProxy::\$errCode.#'
     - '#Property Swoole\\Server::\$admin_server \(Swoole\\Coroutine\\Http\\Server\) does not accept null.#'
     - '#Return type \(Swoole\\StringObject\) of method Swoole\\ArrayObject::serialize\(\) should be compatible with return type \(string\|null\) of method Serializable::serialize\(\)#'
-    - '#Property Swoole\\ConnectionPool::\$pool \(Swoole\\Coroutine\\Channel\) does not accept null.#'
     - '#Parameter \#1 \$response of method Swoole\\Coroutine\\FastCGI\\Proxy::translateResponse\(\) expects Swoole\\FastCGI\\HttpResponse, Swoole\\FastCGI\\Response given.#'
     - '#Parameter \#1 \$object of function spl_object_hash expects object, array given.#'

src/core/ConnectionPool.php

@@ -17,26 +17,19 @@ class ConnectionPool
 {
     public const DEFAULT_SIZE = 64;
 
-    /** @var Channel */
-    protected $pool;
+    protected ?Channel $pool;
 
     /** @var callable */
     protected $constructor;
 
-    /** @var int */
-    protected $size;
+    protected int $size;
 
-    /** @var int */
-    protected $num = 0;
+    protected int $num = 0;
 
-    /** @var string|null */
-    protected $proxy;
-
-    public function __construct(callable $constructor, int $size = self::DEFAULT_SIZE, ?string $proxy = null)
+    public function __construct(callable $constructor, int $size = self::DEFAULT_SIZE, protected ?string $proxy = null)
     {
         $this->pool        = new Channel($this->size = $size);
         $this->constructor = $constructor;
-        $this->proxy       = $proxy;
     }
 
     public function fill(): void

src/core/Database/MysqliPool.php

@@ -20,12 +20,8 @@
  */
 class MysqliPool extends ConnectionPool
 {
-    /** @var MysqliConfig */
-    protected $config;
-
-    public function __construct(MysqliConfig $config, int $size = self::DEFAULT_SIZE)
+    public function __construct(protected MysqliConfig $config, int $size = self::DEFAULT_SIZE)
     {
-        $this->config = $config;
         parent::__construct(function () {
             $mysqli = new \mysqli();
             foreach ($this->config->getOptions() as $option => $value) {

src/core/Database/PDOPool.php

@@ -20,15 +20,8 @@
  */
 class PDOPool extends ConnectionPool
 {
-    /** @var int */
-    protected $size = 64;
-
-    /** @var PDOConfig */
-    protected $config;
-
-    public function __construct(PDOConfig $config, int $size = self::DEFAULT_SIZE)
+    public function __construct(protected PDOConfig $config, int $size = self::DEFAULT_SIZE)
     {
-        $this->config = $config;
         parent::__construct(function () {
             $driver = $this->config->getDriver();
             return new \PDO(