Add compute tags for constraint gammas in worldtube evolution #6404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knelli2
requested changes
Dec 11, 2024
Comment on lines
859
to
863
| * evolution. | ||
| */ | ||
| struct ConstraintGamma2Compute : CurvedScalarWave::Tags::ConstraintGamma2, |
There was a problem hiding this comment.
Please update the dox for both these compute tags to point to the InitializeConstraintDampingGammas mutator which has the exact equations and values that are used.
nikwit
force-pushed
the
worldtube-gammas
branch
from
2a6bfcb to
c55a6ed
Compare
knelli2
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
A stable worldtube evolution requires the profile of gamma2 to track the position of the particle. This PR includes this with a compute tag.