Add pybindings for Spherepack #6412
Merged
+176
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsvu
requested changes
Dec 12, 2024
src/NumericalAlgorithms/SphericalHarmonics/Python/Spherepack.cpp
Outdated
Show resolved
Hide resolved
tests/Unit/NumericalAlgorithms/SphericalHarmonics/Python/Test_Spherepack.py
Outdated
Show resolved
Hide resolved
nikwit
force-pushed
the
ylm-phys-spec
branch
from
d7fe9fe to
e8ed5f1
Compare
nilsvu
approved these changes
Dec 12, 2024
nikwit
force-pushed
the
ylm-phys-spec
branch
from
e8ed5f1 to
07f1b02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds some pybindings for
Spherepack, mostlyphys_to_specandspec_to_phys. I also added bindings for theSpherpackIteratorto write a sensible unit test comparing to scipy.