Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce StaticCache compile time #6426

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

nilsdeppe
Copy link
Member

Proposed changes

Some timings on mbot:

Timings for DgSubcell/Matrices.cpp
 Original: 46
 Combine static cache generate_tuple functions: 46
 Move integral static cache range check: 40
 Change StaticCache enum indexing and bounds check:  22
 Combine enum and integer caching logic in StaticCache: 20
Improve StaticCache compilation time using multiple peelings: 10
Simplifying DgSubcell matrix caching code: 12

The last commit simplifies the code quite a bit, IMO, which is why I did it.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant