[Ready to review/merge] Create a new vagrant environment #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should add a new documentation section into the general documentation: how to install. Yea its easy now, but should get an own chapter. |
|
the broken travis is caused by invalid dependencies located in the composer.lock. |
|
Yea and that bug lives that long, cause the composer cache hides him. We have seen those zend repo problems 2 month ago in our projects. So we should fix them. either here, if the other like our box, orin a separate PR. |
| database_user: | ||
| database_password: | ||
| database_host: localhost | ||
| database_port: 3306 |
There was a problem hiding this comment.
I think we should keep that .distas it is and use a separate one for the box with complete pdo_mysql as driver for the mysq created in the box. The pdo_sqlite is used for an easy entry point.
There was a problem hiding this comment.
+1 - have a config file template for parameters.yml in the place where the other config file templates for vagrant live
|
ok, but I have to find some time for that ;) |
Ma27
changed the title
|
No worries, we can do that together on a slackday, when you are at the buro. |
|
If I'm right, at the 14th august is the next slacktime and then I should have time ;) |
|
hrmpf these zend dependencies seem to require php 5.5, but the sandbox requires php 5.3.x. It seems as we have to remove these deps in order to provide BC for older php versions (which are actually dead btw) |
|
I will ask Reno how he solved that issue in our project. But i think, when lifting up the version is the only sollution, we should do it in an other Issue/PR. So we would have it available in the other PRs too. What would you think @dbu @dantleech |
|
the question is where is this zend stuff required? I would try to remove this if possible, but I'll wait for the response @dbu and @dantleech |
|
the newest versions of zend requires php 5.5 but the version we need at minimum should still support php 5.3 so composer should find a solution. ah, unless we commit the composer.lock file built on a machine with php > 5.3 |
|
|
||
| ## Apply vagrant box | ||
|
|
||
| There's a new vagrant box that is simple to boot: |
There was a problem hiding this comment.
the readme is not time-based so we should not say "new vagrant box" but simply: "The easiest way to set up the sandbox is using Vagrant:"
There was a problem hiding this comment.
I would suggest to provide some docs around the sandbox and its install in our common docs.
|
@dbu, @ElectricMaxxx I'll have to find some time, but I'll fix the docs as soon as possible. why puppet? Well at the mayflower barcamp I've asked @ElectricMaxxx whether there's a vagrant box for the CMF, but there's just one which doesn't work properly, so we got the idea to configure wasted (https://github.com/mayflower/wasted) for the cmf and I could open the pull request. app_dev.php: 👎 It is possible to set a "production" key in the common.yaml to true and then the app.php will be used instead of the app_dev.php (I should really extend the docs): https://github.com/Ma27/cmf-sandbox/blob/vagrant-box/vagrant-cfg/common.yaml#L14. php 5.3 issue: the disadvantage would be that people having a php 5.3 machine on their pc are the only one who are allowed to update the dependencies. the ip will be set by vagrant and is accessible in the private network of your pc only (and is changeable, too: https://github.com/Ma27/cmf-sandbox/blob/vagrant-box/vagrant-cfg/common.yaml#L16 what do you mean with "do we need all these files"? I'm not sure whether I understood you right, but do you mean writing a script that downloads the environment automatically and does all the stuff automaticall. |
|
As one of the developers of wasted I'm not sure if you really want to use the full wasted stack here. IMHO it would make more sense to rip out the puppet classes that are needed because wasted supports much more stuff than needed for this project. The idea behind wasted is to have a quick way to bootstrap and create a vagrant development environment for new or existing projects for our customers with all possible use cases, i.e. nodejs, Oracle Instantclient. That's why you can find all kinds of commented out examples in the Hiera YAML files, which act as a simple documentation. But in this case all the functionality in the form of puppet manifests and the hiera configuration is too much cruft IMHO. If you keep the directory structure (but delete not needed files), even fixes from wasted could be cherry-picked and subtree-merged if needed. The developers of this project need to decide which way to go. We will definitely continue to maintain wasted. |
|
thank you @fpletz for your reply. so you suggest to remove not necessary files, don't you? I think I'll have time for that at the next slackday. |
|
as this is no git submodule, i think not that git can help with syncing
in this case. but you could just diff the files that we still have. on
the other hand, we probably don't need that much syncing either. as i
understood, wasted is more of a copy-paste source for project setup. as
soon as we start to customize the files, things become unreadable.
|
|
what do you mean with "customize the files"? |
| @@ -0,0 +1,26 @@ | |||
| class jackrabbit( | |||
There was a problem hiding this comment.
the actual reason of this module was to separate the jackrabbit-specific code, but now I've solved the jackrabbit issues using the shell provisioner and that's just something like an initializer (comparable to the behavior of the cmf::infrastructure::phpcr::mysql_wrapper, so it should be moved there.
|
squashed everything, should be ready to review /cc @ElectricMaxxx @dbu |
|
I would like to figure it out whether there's a better solution for my export hack |
Ma27
changed the title
|
ping @dbu @ElectricMaxxx |
|
can you rebase once more? |
|
I'll rebase tonight |
- vagrant with an ubuntu trusty - stack with customizable parameters (hostname/ip/php version) - support for the jackrabbit and doctrine-dbal implementations of jackalope
|
@lsmith77 ok, rebased master |
|
ping @lsmith77 |
|
it would be good if by default after |
|
the folder can be set with having a cd /var/www/cmf in .bashrc
|
|
ok, I'll fix that... |
|
@lsmith77 the vhost name is located in the common.yaml, for parameters for the VM are located in the "vagrant/machine.yaml", but I'll find a solution for that. |
|
hmm something isn't quite working yet for me .. I end up with a white page and I see nothing come up in the dev/prod logs nor in the error.log |
|
could you please show me the log output shown when running "vagrant up"? |
|
ping @lsmith77 could you please show me the output log when running |
|
looks like there are some issues with DB creation |
|
thx for your error report. This error occurs if you run vagrant provision/up multiple times as the database exist after some installs already (must be fixed before merging). |
|
closing because of #344 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks: