-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement sitemap and error handling of seo-bundle #352
Open
ElectricMaxxx
wants to merge
12
commits into
master
Choose a base branch
from
seo_sitemap_and_error_handling
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
f7841da
implement sitemap and error handling of seo-bundle
ElectricMaxxx 42475f6
changes due to hints of styleCI
ElectricMaxxx c1a67a2
re-add former error text and information
ElectricMaxxx 482cfc1
test for error page
ElectricMaxxx 32764d2
add error description page
ElectricMaxxx b566cf7
remove french translation
ElectricMaxxx 11714cb
fix ci test
ElectricMaxxx f9fea5e
fix issues due to hints
ElectricMaxxx ae1ba37
Apply fixes from StyleCI
ElectricMaxxx 99620d1
Merge pull request #355 from symfony-cmf/analysis-8wkK9e
ElectricMaxxx 42081c0
translate seo examples
dbu 19dea4f
Merge pull request #356 from symfony-cmf/seo-translations
dbu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,11 +24,7 @@ | |
* | ||
* @author Maximilian Berghoff <[email protected]> | ||
*/ | ||
class DemoSeoExtractor extends DemoSeoContent implements | ||
TitleReadInterface, | ||
DescriptionReadInterface, | ||
OriginalUrlReadInterface, | ||
KeywordsReadInterface | ||
class DemoSeoExtractor extends DemoSeoContent implements TitleReadInterface, DescriptionReadInterface, OriginalUrlReadInterface, KeywordsReadInterface | ||
{ | ||
/** | ||
* {@inheritdoc} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rather disable this fixer and keep this multiline to make it readable. put
disabled: [single_line_class_definition]
into .styleci.ymlThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh. we should use that everywhere, cause i saw that on seo-bundle yesterday too. from which coding style is that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouter added it in one of the bundles, can't remember which one