allow installation with symfony 6 #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dbu
commented
Feb 17, 2024
dbu
commented
| Q | A |
|---|---|
| Branch? | "master" |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
dbu
force-pushed
the
sf6
branch
6 times, most recently
from
7e30508 to
af3ca96
Compare
[ci skip] [skip ci]
dbu
force-pushed
the
sf6
branch
2 times, most recently
from
7bf9243 to
44c19d0
Compare
dbu
commented
Feb 19, 2024
|
@dbu is there anything I can help with to move the PR forward? |
|
i meanwhile tagged routing and testing, so we can change the composer.json. if you have time to pick up from this branch and try to fix the remaining errors, that would be awesome. otherwise i try to look into it again later this week, honestly forgot about this one. |
|
Ok, I will try to take a look at the failing tests! |
dbu
force-pushed
the
sf6
branch
3 times, most recently
from
096c67e to
b71e83b
Compare
|
after rebasing, the failure is gone 🎉 did some more cleanups and released https://github.com/symfony-cmf/core-bundle/releases/tag/3.0.0 let me know if anything fails (or do fix PRs) but the CI is happy, so i tagged 3.0.0 already 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.