-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sf7 #488
Conversation
dbu
commented
Feb 17, 2024
Q | A |
---|---|
Branch? | "master" |
Bug fix? | no |
New feature? | no |
BC breaks? | no |
Deprecations? | no |
Fixed tickets | - |
License | MIT |
Doc PR | - |
999a75f
to
90cdcc4
Compare
04eb98e
to
85ad9d4
Compare
Hi @dbu, is there anything I can do to help move this PR forward and have Symfony 7 support released? |
thanks for asking. there are a bunch of dependencies i have not yet released in new versions. i hope i am getting there soon. |
No worries! If you need some help or I need to test anything, just let me know! |
73b94de
to
54bfbe4
Compare
87f6c4c
to
d37a72c
Compare
c6fe54b
to
fdc3827
Compare
"symfony/translation": "^6.4 || ^7.0", | ||
"symfony/validator": "^6.4 || ^7.0", | ||
"symfony/twig-bundle": "^6.4 || ^7.0", | ||
"symfony-cmf/testing": "dev-fix-test-kernel as 5.0.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adjust before merging
b13ddd3
to
18db2ad
Compare
will need some more testing and the slightly BC breaking cleanups for strict typing before releasing, but we are getting there \o/ |
just realized we don't do a new major version here. so no additional strict typing in src. @acrobat @alexander-schranz i would be glad if you can test the current 3.x branch and open issues or confirm here if it works for you, both on older projects without updating anything else, and on a symfony 7 project. |
I did test sulu/sulu manually the routing still seems to work like expected. Over composer I can not install the current versions because |
strange about not being able to install symfony-cmf/routing 3.0.3 - i had created the tag in february already, i can see it on packagist: https://packagist.org/packages/symfony-cmf/routing#3.0.3 (but i forgot to create the release entry in github - but packagist looks at the git tags, not at github releases) |
@dbu I've tested the routing-bundle 3.x-dev against symfony 6.4 and everything seems to be working so far! I'm not able to test with symfony 7 yet as I'm still waiting for other libraries to add compatiblity. |