Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sf7 #488

Merged
merged 7 commits into from
Apr 6, 2024
Merged

Sf7 #488

merged 7 commits into from
Apr 6, 2024

Conversation

dbu
Copy link
Member

@dbu dbu commented Feb 17, 2024

Q A
Branch? "master"
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets -
License MIT
Doc PR -

@dbu dbu force-pushed the sf7 branch 2 times, most recently from 999a75f to 90cdcc4 Compare February 17, 2024 17:51
composer.json Outdated Show resolved Hide resolved
@dbu dbu force-pushed the sf7 branch 9 times, most recently from 04eb98e to 85ad9d4 Compare February 18, 2024 22:50
composer.json Outdated Show resolved Hide resolved
@acrobat
Copy link
Contributor

acrobat commented Apr 1, 2024

Hi @dbu, is there anything I can do to help move this PR forward and have Symfony 7 support released?

@dbu
Copy link
Member Author

dbu commented Apr 2, 2024

thanks for asking. there are a bunch of dependencies i have not yet released in new versions. i hope i am getting there soon.

@acrobat
Copy link
Contributor

acrobat commented Apr 3, 2024

No worries! If you need some help or I need to test anything, just let me know!

@dbu dbu force-pushed the sf7 branch 2 times, most recently from 73b94de to 54bfbe4 Compare April 3, 2024 20:20
@dbu dbu force-pushed the sf7 branch 3 times, most recently from 87f6c4c to d37a72c Compare April 6, 2024 09:40
@dbu dbu force-pushed the sf7 branch 2 times, most recently from c6fe54b to fdc3827 Compare April 6, 2024 15:13
"symfony/translation": "^6.4 || ^7.0",
"symfony/validator": "^6.4 || ^7.0",
"symfony/twig-bundle": "^6.4 || ^7.0",
"symfony-cmf/testing": "dev-fix-test-kernel as 5.0.2",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adjust before merging

@dbu dbu force-pushed the sf7 branch 2 times, most recently from b13ddd3 to 18db2ad Compare April 6, 2024 15:19
@dbu dbu merged commit 389449f into 3.x Apr 6, 2024
6 checks passed
@dbu dbu deleted the sf7 branch April 6, 2024 15:22
@dbu
Copy link
Member Author

dbu commented Apr 6, 2024

will need some more testing and the slightly BC breaking cleanups for strict typing before releasing, but we are getting there \o/

@dbu
Copy link
Member Author

dbu commented Apr 6, 2024

just realized we don't do a new major version here. so no additional strict typing in src.

@acrobat @alexander-schranz i would be glad if you can test the current 3.x branch and open issues or confirm here if it works for you, both on older projects without updating anything else, and on a symfony 7 project.

@alexander-schranz
Copy link
Contributor

I did test sulu/sulu manually the routing still seems to work like expected. Over composer I can not install the current versions because 3.0.3 of symfony-cmf/routing is not tagged yet and so even composer config minimum-stability dev can not install it but I manually checkout symfony-cmf/routing and symfony-cmf/routing-bundle 3.x branches manually in my vendor and it seems to work like expected.

@dbu
Copy link
Member Author

dbu commented Apr 7, 2024

strange about not being able to install symfony-cmf/routing 3.0.3 - i had created the tag in february already, i can see it on packagist: https://packagist.org/packages/symfony-cmf/routing#3.0.3 (but i forgot to create the release entry in github - but packagist looks at the git tags, not at github releases)

@acrobat
Copy link
Contributor

acrobat commented Apr 7, 2024

@dbu I've tested the routing-bundle 3.x-dev against symfony 6.4 and everything seems to be working so far! I'm not able to test with symfony 7 yet as I'm still waiting for other libraries to add compatiblity.

@dbu
Copy link
Member Author

dbu commented Apr 15, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants