Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to PHPStan 2 #1547

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Upgrade to PHPStan 2 #1547

wants to merge 1 commit into from

Conversation

rosier
Copy link
Contributor

@rosier rosier commented Dec 11, 2024

This PR:

  • Upgrades to PHPStan 2
  • Adds a separate test job for PHPStan
  • Turns off the doctrine rules
  • Merges the config files phpstan.dist.neon and phpstan.neon.dist

I disabled the doctrine rules because all the errors coming from this were basically ignored permanently anyway.

I keep the config file phpstan.dist.neon from the recipe https://github.com/symfony/recipes-contrib/blob/main/phpstan/phpstan/1.0/phpstan.dist.neon and added the rest of the config into that file.

Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants