Skip to content

Commit

Permalink
Merge branch '6.3' into 6.4
Browse files Browse the repository at this point in the history
* 6.3:
  [Form] Fix merging form data and files (ter)
  [Intl] Update the ICU data to 74.1
  [Scheduler] Use MockClock
  [HtmlSanitizer] Consider `width` attribute as safe
  [DoctrineBridge] Fix exception message
  [Security][Validator] Missing translations for Luxembourgish
  • Loading branch information
fabpot committed Oct 28, 2023
2 parents 8e7311c + c8af292 commit 175eed1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Form/ChoiceList/DoctrineChoiceLoader.php
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public function __construct(
private readonly ?EntityLoaderInterface $objectLoader = null,
) {
if ($idReader && !$idReader->isSingleId()) {
throw new \InvalidArgumentException(sprintf('The second argument "$idReader" of "%s" must be null when the query cannot be optimized because of composite id fields.', __METHOD__));
throw new \InvalidArgumentException(sprintf('The "$idReader" argument of "%s" must be null when the query cannot be optimized because of composite id fields.', __METHOD__));
}

$this->class = $manager->getClassMetadata($class)->getName();
Expand Down
2 changes: 1 addition & 1 deletion Tests/Form/ChoiceList/DoctrineChoiceLoaderTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ public function testLoadChoicesForValuesLoadsOnlyChoicesIfValueIsIdReader()
public function testPassingIdReaderWithoutSingleIdEntity()
{
$this->expectException(\InvalidArgumentException::class);
$this->expectExceptionMessage('The second argument "$idReader" of "Symfony\\Bridge\\Doctrine\\Form\\ChoiceList\\DoctrineChoiceLoader::__construct" must be null when the query cannot be optimized because of composite id fields.');
$this->expectExceptionMessage('The "$idReader" argument of "Symfony\\Bridge\\Doctrine\\Form\\ChoiceList\\DoctrineChoiceLoader::__construct" must be null when the query cannot be optimized because of composite id fields.');

$idReader = $this->createMock(IdReader::class);
$idReader->expects($this->once())
Expand Down

0 comments on commit 175eed1

Please sign in to comment.