Adding window-size #461
Open
Adding window-size #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I haven't tested Chrome; it's taken from symfony#428 (which can be closed now IMO) Firefox works for me; it's taken from https://stackoverflow.com/a/64374604/1668200
dunglas
approved these changes
Apr 16, 2021
dunglas
requested changes
Jul 12, 2021
| ``` | ||
| Firefox: | ||
| ```php | ||
| use Facebook\WebDriver\WebDriverDimension; |
There was a problem hiding this comment.
Passing the --window-size argument to createFirefoxClient() should work isn't it?
There was a problem hiding this comment.
Hm, doing a quick check, this is not working for me:
$client = Client::createFirefoxClient(null, ['--window-size=2500,4000']]);At least the screenshot I'm getting is smaller (1280x955)
I can't remember exactly, but I guess that I did try this first, when I wrote the PR. If it would have been that easy, I wouldn't have dug out the $client->manage()->window()->setSize($size); way...
There was a problem hiding this comment.
found this while googling for the window size setting.
$size = new WebDriverDimension(1500, 2000);
$client->manage()->window()->setSize($size);
worked for me
Co-authored-by: Kévin Dunglas <[email protected]>
Co-authored-by: Kévin Dunglas <[email protected]>
Co-authored-by: Kévin Dunglas <[email protected]>
Co-authored-by: Kévin Dunglas <[email protected]>
Co-authored-by: Kévin Dunglas <[email protected]>
Co-authored-by: Kévin Dunglas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't tested Chrome; it's taken from #428 (which can be closed now IMO)
Firefox works for me; it's taken from https://stackoverflow.com/a/64374604/1668200