Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Port #465

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adding Port #465

wants to merge 1 commit into from

Conversation

ThomasLandauer
Copy link
Contributor

Haven't tested for Chrome.

Haven't tested for Chrome.
@dunglas
Copy link
Member

dunglas commented Jul 12, 2021

I would prefer adding a more generic section explaining how to pass options to the drivers, similar to the existing Passing Arguments to ChromeDriver section. WDYT?

@ThomasLandauer
Copy link
Contributor Author

No, sorry, I have too little overview.

So while I do agree with what I think is your bottom line (namely that README is a bit unorganized right now :-) I can't guess in which direction you want to evolve it ;-)
Ultimately, the page is getting to long anyway, and should be separated into a dedicated (sub)website. But since this would probably be a larger undertaking, the best guess for now is probably: Merge this as is, and do the larger reorganization later...

@dunglas
Copy link
Member

dunglas commented Jul 12, 2021

Maybe should we just move these docs in symfony/symfony-docs? Panther reached 1.0 anyway, so it's probably the good time. WDYT @symfony/team-symfony-docs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants