feat: allow selenium server with internal webserver #621
Conversation
What "permission", thank you so much for working on this! \o/ :smile: |
|
Coding Standards fails seem unrelated. @dkarlovi Ok, let's rephrase it then. 😄 |
|
@daFish this looks completed to me, why did you leave is as a draft? |
daFish
force-pushed
the
feat/selenium-devserver
branch
from
db389e2 to
55dad6c
Compare
I made a small info in the README about it. I will remove the draft status and this is good to go. |
|
@dunglas Is there anything missing here so it can be merged? |
daFish
force-pushed
the
feat/selenium-devserver
branch
2 times, most recently
from
1d1929e to
8a59fd8
Compare
|
Not sure if the coding standards issues are related. Running the check locally revealed issues in 10 files. |
src/PantherTestCaseTrait.php
Outdated
| @@ -185,7 +185,9 @@ protected static function createPantherClient(array $options = [], array $kernel | |||
|
|
|||
| if (PantherTestCase::FIREFOX === $browser) { | |||
| self::$pantherClients[0] = self::$pantherClient = Client::createFirefoxClient(null, $browserArguments, $managerOptions, self::$baseUri); | |||
| } else { | |||
| } elseif (PantherTestCase::SELENIUM === $browser) { | |||
| self::$pantherClients[0] = self::$pantherClient = Client::createSeleniumClient($managerOptions['host'], $managerOptions['capabilities'], self::$baseUri, $options); | |||
There was a problem hiding this comment.
| self::$pantherClients[0] = self::$pantherClient = Client::createSeleniumClient($managerOptions['host'], $managerOptions['capabilities'], self::$baseUri, $options); | |
| self::$pantherClients[0] = self::$pantherClient = Client::createSeleniumClient($managerOptions['host'], $managerOptions['capabilities'] ?? null, self::$baseUri, $options); |
Or you need to validate the manager options to enforce the key is defined.
and for host, you probably need to validate it as well.
Also, passing $options looks inconsistent with the case of other factories that are passing $managerOptions instead.
daFish
force-pushed
the
feat/selenium-devserver
branch
from
8a59fd8 to
cd19f51
Compare
daFish
force-pushed
the
feat/selenium-devserver
branch
from
cd19f51 to
7b67002
Compare
|
Added the suggestions to the README.md and squashed my commits. |
daFish
force-pushed
the
feat/selenium-devserver
branch
from
7b67002 to
0a971e3
Compare
daFish
force-pushed
the
feat/selenium-devserver
branch
from
0a971e3 to
9d693e4
Compare
Implements #590 by @dkarlovi.
This change allows the usage of an external selenium instance (e.g. via docker compose) to test against the internal webserver.
Todos: