Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for symfony-monday-api-bundle #1520

Closed
wants to merge 2 commits into from
Closed

Add recipe for symfony-monday-api-bundle #1520

wants to merge 2 commits into from

Conversation

gponty
Copy link
Contributor

@gponty gponty commented Jun 5, 2023

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) June 5, 2023 12:23
@github-actions
Copy link

github-actions bot commented Jun 5, 2023

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1520/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1520/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'gponty/symfony-monday-api-bundle:^1.0'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

auto-merge was automatically disabled August 10, 2023 09:39

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) August 10, 2023 09:40
@@ -0,0 +1,3 @@
# Read the documentation: https://github.com/gponty/symfony-monday-api/blob/main/README.md
monday:
api_key: '%env(resolve:MONDAY_API_KEY)%'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the API key is a scalar, there is no need to "resolve", isn't it?

Suggested change
api_key: '%env(resolve:MONDAY_API_KEY)%'
api_key: '%env(MONDAY_API_KEY)%'

@OskarStark
Copy link
Contributor

Lets close due to lack of response

@OskarStark OskarStark closed this Sep 27, 2023
auto-merge was automatically disabled September 27, 2023 08:55

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants