Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for Sylius Media Manager plugin #1535

Merged

Conversation

maximehuran
Copy link
Contributor

@maximehuran maximehuran commented Aug 18, 2023

Q A
License MIT
Packagist monsieurbiz/sylius-media-manager-plugin

It's a Sylius plugin it will not works with Symfony only.
See our Recipe workflow which test it in our custom recipes repository.

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) August 18, 2023 13:03
@github-actions
Copy link

github-actions bot commented Aug 18, 2023

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1535/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1535/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'monsieurbiz/sylius-media-manager-plugin:^1.0'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

@fabpot
Copy link
Member

fabpot commented Aug 30, 2023

Can you fix the errors (indentation)?

auto-merge was automatically disabled October 2, 2023 14:49

Head branch was pushed to by a user without write access

@maximehuran maximehuran force-pushed the feature/sylius-media-manager branch from 0ce0d4f to f434546 Compare October 2, 2023 14:49
@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) October 2, 2023 14:49
auto-merge was automatically disabled October 2, 2023 14:49

Head branch was pushed to by a user without write access

@maximehuran maximehuran force-pushed the feature/sylius-media-manager branch from f434546 to 1f042ca Compare October 2, 2023 14:49
@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) October 2, 2023 14:50
@maximehuran
Copy link
Contributor Author

Done for the indentation 👌

@symfony-recipes-bot symfony-recipes-bot merged commit 970ed1e into symfony:main Oct 2, 2023
1 of 2 checks passed
@maximehuran maximehuran deleted the feature/sylius-media-manager branch October 2, 2023 15:07
OskarStark pushed a commit to OskarStark/recipes-contrib that referenced this pull request Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants