Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datana-gmbh/fake-api-client version 2 #1547

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

OskarStark
Copy link
Contributor

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) October 9, 2023 08:23
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1547/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1547/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'datana-gmbh/fake-api-client:^2.0'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

datana-gmbh/fake-api-client

1.0 vs 2.0
diff --git a/datana-gmbh/fake-api-client/1.0/config/packages/datana_fake_api.yaml b/datana-gmbh/fake-api-client/2.0/config/packages/datana_fake_api.yaml
index b7436991..64abf2b8 100644
--- a/datana-gmbh/fake-api-client/1.0/config/packages/datana_fake_api.yaml
+++ b/datana-gmbh/fake-api-client/2.0/config/packages/datana_fake_api.yaml
@@ -2,21 +2,12 @@ services:
     _defaults:
         autowire: true
 
-    Datana\FakeApi\Api\FakeApiClient:
+    Datana\FakeApi\FakeApiClient:
         arguments:
             - '%env(FAKE_API_BASE_URI)%'
             - '%env(FAKE_API_USERNAME)%'
             - '%env(FAKE_API_PASSWORD)%'
             - '%env(bool:FAKE_API_DISABLE_CACHE)%'
 
-    Datana\FakeApi\Api\Formulario\DateneingabenApi: null
-    Datana\FakeApi\Api\Formulario\StatisticsApi: null
-when@dev:
-    services:
-        Datana\Formulario\Api\DateneingabenApiInterface: '@Datana\FakeApi\Api\Formulario\DateneingabenApi'
-        Datana\Formulario\Api\StatisticsApiInterface: '@Datana\FakeApi\Api\Formulario\StatisticsApi'
-
-when@test:
-    services:
-        Datana\Formulario\Api\DateneingabenApiInterface: '@Datana\FakeApi\Api\Formulario\DateneingabenApi'
-        Datana\Formulario\Api\StatisticsApiInterface: '@Datana\FakeApi\Api\Formulario\StatisticsApi'
+    Datana\FakeApi\Formulario\DateneingabenApi: null
+    Datana\FakeApi\Formulario\StatisticsApi: null

@OskarStark OskarStark requested a review from fabpot October 9, 2023 08:27
@symfony-recipes-bot symfony-recipes-bot merged commit abc548e into symfony:main Oct 9, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants