Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial version for survos/command-bundle #1548

Closed
wants to merge 7 commits into from
Closed

Conversation

tacman
Copy link
Contributor

@tacman tacman commented Oct 15, 2023

Q A
License MIT
Packagist https://packagist.org/packages/survos/command-bundle

Add default configuration and routing to survos/command-bundle

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) October 15, 2023 11:41
@github-actions
Copy link

github-actions bot commented Oct 15, 2023

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1548/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1548/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'survos/command-bundle:^1.5' 'survos/crawler-bundle:^1.5'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

auto-merge was automatically disabled October 16, 2023 10:38

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) October 16, 2023 10:38
auto-merge was automatically disabled October 16, 2023 11:23

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) October 16, 2023 11:23
auto-merge was automatically disabled October 16, 2023 14:36

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) October 16, 2023 14:37
auto-merge was automatically disabled October 16, 2023 14:40

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) October 16, 2023 14:40
auto-merge was automatically disabled October 16, 2023 14:43

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) October 16, 2023 14:43
@tacman
Copy link
Contributor Author

tacman commented Oct 16, 2023

How do I set this PR up so that it's one PR for each bundle? I have the command-bundle and crawler-bundle, should they each be in separate branches in my fork?

auto-merge was automatically disabled October 16, 2023 18:31

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) October 16, 2023 18:31
@weaverryan
Copy link
Member

Yup, put them in separate branches on your fork. So create a new branch, move the crawler-bundle stuff to that new branch, then push that new branch and make a 2nd PR

@tacman
Copy link
Contributor Author

tacman commented Oct 17, 2023

Done! So I'll close this.

@tacman tacman closed this Oct 17, 2023
auto-merge was automatically disabled October 17, 2023 17:32

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants