Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for simply-stream/twitch-api-bundle:0.1 #1557

Conversation

aaricdev
Copy link
Contributor

Q A
License MIT
Packagist https://packagist.org/packages/simply-stream/twitch-api-bundle

Versions in packagist currently have the prefix "v" (it's my first contribution, will this interfere?) but I'll remove it in due time.

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) October 26, 2023 13:16
@github-actions
Copy link

github-actions bot commented Oct 26, 2023

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1557/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1557/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'simply-stream/twitch-api-bundle:^0.1'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

@fabpot
Copy link
Member

fabpot commented Oct 27, 2023

Can you fix the missing empty lines?
Having v as a prefix for your versions is not an issue.

auto-merge was automatically disabled October 27, 2023 11:58

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) October 27, 2023 11:59
@aaricdev
Copy link
Contributor Author

Should be added now, but it looks like I need to set it up on a clean environment to fix the last errors.

auto-merge was automatically disabled October 27, 2023 20:23

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) October 27, 2023 20:24
@symfony-recipes-bot symfony-recipes-bot merged commit 579c39c into symfony:main Oct 28, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants