Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 21torr/hosting bundle #1565

Merged
merged 1 commit into from
Jan 1, 2024
Merged

Conversation

apfelbox
Copy link
Contributor

Q A
License MIT
Packagist https://packagist.org/packages/21torr/hosting

Here are the definitions for 21torr/hosting.

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) November 17, 2023 14:36
Copy link

github-actions bot commented Nov 17, 2023

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1565/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1565/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req '21torr/hosting:^2.1'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

@apfelbox
Copy link
Contributor Author

apfelbox commented Nov 17, 2023

Second CI failure seems to be related to this package being PHP 8.2 only. What should I do about it – this package will be 8.2+ only?

auto-merge was automatically disabled November 17, 2023 16:05

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) November 17, 2023 16:05
auto-merge was automatically disabled November 17, 2023 16:23

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) November 17, 2023 16:23
@apfelbox
Copy link
Contributor Author

Is there anything I need to do for this pull request?

@symfony-recipes-bot symfony-recipes-bot merged commit 051947f into symfony:main Jan 1, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants