Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix recipe for nelmio/solarium-bundle ^5.0 #1568

Merged

Conversation

dmaicher
Copy link
Contributor

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) November 20, 2023 18:17
Copy link

github-actions bot commented Nov 20, 2023

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1568/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1568/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'nelmio/solarium-bundle:^5.0'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

nelmio/solarium-bundle

2.4 vs 5.0
diff --git a/nelmio/solarium-bundle/2.4/config/packages/nelmio_solarium.yaml b/nelmio/solarium-bundle/5.0/config/packages/nelmio_solarium.yaml
index 19af2a5b..f0823aad 100644
--- a/nelmio/solarium-bundle/2.4/config/packages/nelmio_solarium.yaml
+++ b/nelmio/solarium-bundle/5.0/config/packages/nelmio_solarium.yaml
@@ -7,7 +7,8 @@ nelmio_solarium:
             # scheme: http
             # port: 8983
             # path: /solr
-            # timeout: 5
     clients:
         default:
             endpoints: [default]
+            # You can customize the http timeout (in seconds) here. The default is 5sec.
+            # adapter_timeout: 5

auto-merge was automatically disabled November 20, 2023 18:18

Head branch was pushed to by a user without write access

@dmaicher dmaicher force-pushed the nelmio_solarium_bundle_fix branch from 14c70ab to b1b4424 Compare November 20, 2023 18:18
@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) November 20, 2023 18:19
auto-merge was automatically disabled November 20, 2023 18:39

Head branch was pushed to by a user without write access

@dmaicher dmaicher force-pushed the nelmio_solarium_bundle_fix branch from b1b4424 to 81b29fa Compare November 20, 2023 18:39
@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) November 20, 2023 18:40
@dmaicher
Copy link
Contributor Author

@redflo I fixed the recipe for newer versions of nelmio/solarium-bundle. Could you review and approve this PR? 😊 Thanks.

@symfony-recipes-bot symfony-recipes-bot merged commit c439704 into symfony:main Jan 1, 2024
2 checks passed
@dmaicher dmaicher deleted the nelmio_solarium_bundle_fix branch January 1, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unrecognized option "timeout" under "nelmio_solarium.endpoints.default"
3 participants