Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schranz-search/symfony-bundle config #1575

Merged

Conversation

ToshY
Copy link
Contributor

@ToshY ToshY commented Dec 14, 2023

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) December 14, 2023 23:14
Copy link

github-actions bot commented Dec 14, 2023

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1575/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1575/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'schranz-search/symfony-bundle:^0.2'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

vvasiloi
vvasiloi previously approved these changes Dec 15, 2023
@vvasiloi
Copy link
Contributor

Hey @ToshY , please fix the indentation so the build passes.

auto-merge was automatically disabled December 15, 2023 12:45

Head branch was pushed to by a user without write access

@ToshY ToshY force-pushed the schranz-search-symfony-bundle branch from 77ed2ea to 2f07e19 Compare December 15, 2023 12:45
@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) December 15, 2023 12:45
auto-merge was automatically disabled December 15, 2023 12:46

Head branch was pushed to by a user without write access

@ToshY ToshY force-pushed the schranz-search-symfony-bundle branch from 2f07e19 to 271d001 Compare December 15, 2023 12:46
@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) December 15, 2023 12:47
@ToshY
Copy link
Contributor Author

ToshY commented Dec 15, 2023

Hey @vvasiloi / @alexander-schranz 👋

I've updated the indenting and applied the suggestions.

auto-merge was automatically disabled December 16, 2023 16:16

Head branch was pushed to by a user without write access

@ToshY ToshY force-pushed the schranz-search-symfony-bundle branch from 271d001 to 8acd80b Compare December 16, 2023 16:16
@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) December 16, 2023 16:17
auto-merge was automatically disabled December 16, 2023 16:18

Head branch was pushed to by a user without write access

@ToshY ToshY force-pushed the schranz-search-symfony-bundle branch from 8acd80b to bed3b44 Compare December 16, 2023 16:18
@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) December 16, 2023 16:18
@symfony-recipes-bot symfony-recipes-bot merged commit 3daf0c1 into symfony:main Dec 18, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants