[Meta] Drop format, lint, check-format and check-lint commands, repla…

…ce them with check and ci commands
symfony · Dec 5, 2024 · 51f7478 · 51f7478
1 parent 4d298e8
commit 51f7478
Show file tree

Hide file tree

Showing 22 changed files with 45 additions and 86 deletions.
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -28,8 +28,7 @@ jobs:
                   restore-keys: |
                       ${{ runner.os }}-yarn-
             - run: yarn --immutable
-            - run: yarn check-lint
-            - run: yarn check-format
+            - run: yarn ci
 
     js-dist-current:
         name: Check for UnBuilt JS Dist Files

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -81,14 +81,14 @@ To help you with assets, you can run the following commands in a specific packag
   - `yarn run build`: build (compile) assets from the package,
   - `yarn run watch`: watch for modifications and rebuild assets from the package,
   - `yarn run test`: run the tests from the package,
-  - `yarn run lint`: lint assets from the package,
-  - `yarn run format`: format assets from the package.
+  - `yarn run check`: run the formatter, linter, and sort imports, and fails if any modifications 
+  - `yarn run check --write`: run the formatter, linter, imports sorting, and write modifications 
 
 Thanks to [Yarn Workspaces](https://yarnpkg.com/features/workspaces), you can also run these commands from the root directory of the project:
   - `yarn run build`: build (compile) assets from **all** packages,
   - `yarn run test`: run the tests from **all** packages,
-  - `yarn run lint`: lint assets from **all** packages,
-  - `yarn run format`: format assets from **all** packages,
+  - `yarn run check`: run the formatter, linter, and sort imports for **all** packages, and fails if any modifications
+  - `yarn run check --write`: run the formatter, linter, imports sorting for **all** packages, and write modifications
 
 ## Useful Git commands
 

diff --git a/package.json b/package.json
@@ -8,10 +8,8 @@
     "scripts": {
         "build": "yarn workspaces foreach -Apt run build",
         "test": "yarn workspaces foreach -Apt run test",
-        "lint": "biome lint --write",
-        "format": "biome format --write",
-        "check-lint": "biome lint",
-        "check-format": "biome format"
+        "check": "biome check",
+        "ci": "biome ci"
     },
     "devDependencies": {
         "@babel/core": "^7.25.2",

diff --git a/src/Autocomplete/assets/package.json b/src/Autocomplete/assets/package.json
@@ -9,10 +9,8 @@
         "build": "node ../../../bin/build_package.js .",
         "watch": "node ../../../bin/build_package.js . --watch",
         "test": "../../../bin/test_package.sh .",
-        "lint": "biome lint --write",
-        "format": "biome format --write",
-        "check-lint": "biome lint",
-        "check-format": "biome format"
+        "check": "biome check",
+        "ci": "biome ci"
     },
     "symfony": {
         "controllers": {

diff --git a/src/Chartjs/assets/package.json b/src/Chartjs/assets/package.json
@@ -10,10 +10,8 @@
         "build": "node ../../../bin/build_package.js .",
         "watch": "node ../../../bin/build_package.js . --watch",
         "test": "../../../bin/test_package.sh .",
-        "lint": "biome lint --write",
-        "format": "biome format --write",
-        "check-lint": "biome lint",
-        "check-format": "biome format"
+        "check": "biome check",
+        "ci": "biome ci"
     },
     "symfony": {
         "controllers": {

diff --git a/src/Cropperjs/assets/package.json b/src/Cropperjs/assets/package.json
@@ -12,10 +12,8 @@
         "build": "node ../../../bin/build_package.js .",
         "watch": "node ../../../bin/build_package.js . --watch",
         "test": "../../../bin/test_package.sh .",
-        "lint": "biome lint --write",
-        "format": "biome format --write",
-        "check-lint": "biome lint",
-        "check-format": "biome format"
+        "check": "biome check",
+        "ci": "biome ci"
     },
     "symfony": {
         "controllers": {

diff --git a/src/Dropzone/assets/package.json b/src/Dropzone/assets/package.json
@@ -12,10 +12,8 @@
         "build": "node ../../../bin/build_package.js .",
         "watch": "node ../../../bin/build_package.js . --watch",
         "test": "../../../bin/test_package.sh .",
-        "lint": "biome lint --write",
-        "format": "biome format --write",
-        "check-lint": "biome lint",
-        "check-format": "biome format"
+        "check": "biome check",
+        "ci": "biome ci"
     },
     "symfony": {
         "controllers": {

diff --git a/src/LazyImage/assets/package.json b/src/LazyImage/assets/package.json
@@ -9,10 +9,8 @@
         "build": "node ../../../bin/build_package.js .",
         "watch": "node ../../../bin/build_package.js . --watch",
         "test": "../../../bin/test_package.sh .",
-        "lint": "biome lint --write",
-        "format": "biome format --write",
-        "check-lint": "biome lint",
-        "check-format": "biome format"
+        "check": "biome check",
+        "ci": "biome ci"
     },
     "symfony": {
         "controllers": {

diff --git a/src/LiveComponent/assets/package.json b/src/LiveComponent/assets/package.json
@@ -12,10 +12,8 @@
         "build": "node ../../../bin/build_package.js .",
         "watch": "node ../../../bin/build_package.js . --watch",
         "test": "../../../bin/test_package.sh .",
-        "lint": "biome lint --write",
-        "format": "biome format --write",
-        "check-lint": "biome lint",
-        "check-format": "biome format"
+        "check": "biome check",
+        "ci": "biome ci"
     },
     "symfony": {
         "controllers": {

diff --git a/src/Map/assets/package.json b/src/Map/assets/package.json
@@ -10,10 +10,8 @@
         "build": "node ../../../bin/build_package.js .",
         "watch": "node ../../../bin/build_package.js . --watch",
         "test": "../../../bin/test_package.sh .",
-        "lint": "biome lint --write",
-        "format": "biome format --write",
-        "check-lint": "biome lint",
-        "check-format": "biome format"
+        "check": "biome check",
+        "ci": "biome ci"
     },
     "symfony": {
         "importmap": {

diff --git a/src/Map/src/Bridge/Google/assets/package.json b/src/Map/src/Bridge/Google/assets/package.json
@@ -10,10 +10,8 @@
         "build": "node ../../../../../../bin/build_package.js .",
         "watch": "node ../../../../../../bin/build_package.js . --watch",
         "test": "../../../../../../bin/test_package.sh .",
-        "lint": "biome lint --write",
-        "format": "biome format --write",
-        "check-lint": "biome lint",
-        "check-format": "biome format"
+        "check": "biome check",
+        "ci": "biome ci"
     },
     "symfony": {
         "controllers": {

diff --git a/src/Map/src/Bridge/Leaflet/assets/package.json b/src/Map/src/Bridge/Leaflet/assets/package.json
@@ -10,10 +10,8 @@
         "build": "node ../../../../../../bin/build_package.js .",
         "watch": "node ../../../../../../bin/build_package.js . --watch",
         "test": "../../../../../../bin/test_package.sh .",
-        "lint": "biome lint --write",
-        "format": "biome format --write",
-        "check-lint": "biome lint",
-        "check-format": "biome format"
+        "check": "biome check",
+        "ci": "biome ci"
     },
     "symfony": {
         "controllers": {

diff --git a/src/Notify/assets/package.json b/src/Notify/assets/package.json
@@ -9,10 +9,8 @@
         "build": "node ../../../bin/build_package.js .",
         "watch": "node ../../../bin/build_package.js . --watch",
         "test": "../../../bin/test_package.sh .",
-        "lint": "biome lint --write",
-        "format": "biome format --write",
-        "check-lint": "biome lint",
-        "check-format": "biome format"
+        "check": "biome check",
+        "ci": "biome ci"
     },
     "symfony": {
         "controllers": {

diff --git a/src/React/assets/package.json b/src/React/assets/package.json
@@ -9,10 +9,8 @@
         "build": "node ../../../bin/build_package.js .",
         "watch": "node ../../../bin/build_package.js . --watch",
         "test": "../../../bin/test_package.sh .",
-        "lint": "biome lint --write",
-        "format": "biome format --write",
-        "check-lint": "biome lint",
-        "check-format": "biome format"
+        "check": "biome check",
+        "ci": "biome ci"
     },
     "symfony": {
         "controllers": {

diff --git a/src/StimulusBundle/assets/package.json b/src/StimulusBundle/assets/package.json
@@ -8,10 +8,8 @@
         "build": "node ../../../bin/build_package.js .",
         "watch": "node ../../../bin/build_package.js . --watch",
         "test": "../../../bin/test_package.sh .",
-        "lint": "biome lint --write",
-        "format": "biome format --write",
-        "check-lint": "biome lint",
-        "check-format": "biome format"
+        "check": "biome check",
+        "ci": "biome ci"
     },
     "symfony": {
         "needsPackageAsADependency": false,

diff --git a/src/Svelte/assets/package.json b/src/Svelte/assets/package.json
@@ -8,10 +8,8 @@
         "build": "node ../../../bin/build_package.js .",
         "watch": "node ../../../bin/build_package.js . --watch",
         "test": "../../../bin/test_package.sh .",
-        "lint": "biome lint --write",
-        "format": "biome format --write",
-        "check-lint": "biome lint",
-        "check-format": "biome format"
+        "check": "biome check",
+        "ci": "biome ci"
     },
     "symfony": {
         "controllers": {

diff --git a/src/Swup/assets/package.json b/src/Swup/assets/package.json
@@ -9,10 +9,8 @@
         "build": "node ../../../bin/build_package.js .",
         "watch": "node ../../../bin/build_package.js . --watch",
         "test": "../../../bin/test_package.sh .",
-        "lint": "biome lint --write",
-        "format": "biome format --write",
-        "check-lint": "biome lint",
-        "check-format": "biome format"
+        "check": "biome check",
+        "ci": "biome ci"
     },
     "symfony": {
         "controllers": {

diff --git a/src/TogglePassword/assets/package.json b/src/TogglePassword/assets/package.json
@@ -12,10 +12,8 @@
         "build": "node ../../../bin/build_package.js .",
         "watch": "node ../../../bin/build_package.js . --watch",
         "test": "../../../bin/test_package.sh .",
-        "lint": "biome lint --write",
-        "format": "biome format --write",
-        "check-lint": "biome lint",
-        "check-format": "biome format"
+        "check": "biome check",
+        "ci": "biome ci"
     },
     "symfony": {
         "controllers": {

diff --git a/src/Translator/assets/package.json b/src/Translator/assets/package.json
@@ -9,10 +9,8 @@
         "build": "node ../../../bin/build_package.js .",
         "watch": "node ../../../bin/build_package.js . --watch",
         "test": "../../../bin/test_package.sh .",
-        "lint": "biome lint --write",
-        "format": "biome format --write",
-        "check-lint": "biome lint",
-        "check-format": "biome format"
+        "check": "biome check",
+        "ci": "biome ci"
     },
     "symfony": {
         "importmap": {

diff --git a/src/Turbo/assets/package.json b/src/Turbo/assets/package.json
@@ -10,10 +10,8 @@
         "build": "node ../../../bin/build_package.js .",
         "watch": "node ../../../bin/build_package.js . --watch",
         "test": "../../../bin/test_package.sh .",
-        "lint": "biome lint --write",
-        "format": "biome format --write",
-        "check-lint": "biome lint",
-        "check-format": "biome format"
+        "check": "biome check",
+        "ci": "biome ci"
     },
     "symfony": {
         "controllers": {

diff --git a/src/Typed/assets/package.json b/src/Typed/assets/package.json
@@ -9,10 +9,8 @@
         "build": "node ../../../bin/build_package.js .",
         "watch": "node ../../../bin/build_package.js . --watch",
         "test": "../../../bin/test_package.sh .",
-        "lint": "biome lint --write",
-        "format": "biome format --write",
-        "check-lint": "biome lint",
-        "check-format": "biome format"
+        "check": "biome check",
+        "ci": "biome ci"
     },
     "symfony": {
         "controllers": {

diff --git a/src/Vue/assets/package.json b/src/Vue/assets/package.json
@@ -9,10 +9,8 @@
         "build": "node ../../../bin/build_package.js .",
         "watch": "node ../../../bin/build_package.js . --watch",
         "test": "../../../bin/test_package.sh .",
-        "lint": "biome lint --write",
-        "format": "biome format --write",
-        "check-lint": "biome lint",
-        "check-format": "biome format"
+        "check": "biome check",
+        "ci": "biome ci"
     },
     "symfony": {
         "controllers": {