Avoiding double-wrapping of Twig RuntimeError

[weaverryan]

Q	A
Bug fix?	yes
New feature?	yes
Tickets	None
License	MIT

I had noticed that, when making a typo in my Twig file, the true error was hidden inside a nested exception.

Before (left top of page, right, further down the page)

After

So, you see the exact error now. You lose that the error happened when rendering the InvoiceCreator component, but I think that's not important. And you can find that actually if you look up the stacktrace a bit.

Btw, the reason we want to throw a RuntimeError from Twig is if, when rendering, if you have an error in your PHP code (not template), it makes it look nicer. Without wrapping your PHP error in a RuntimeError, you get:

An exception has been thrown during the rendering of a template ("AHhhh").

After, it is:

Error rendering "Icon" component: AHhhh

So the RuntimeError is 👍 ... but we don't need to create a 2nd one if we already have one.

Cheers!