Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Anonymous component props and Class backed component properties d… #1146

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Fix Anonymous component props and Class backed component properties d… #1146

merged 1 commit into from
Oct 2, 2023

Conversation

WebMamba
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
Tickets Fix #1138
License MIT

weaverryan
weaverryan reviewed Sep 27, 2023
View reviewed changes
Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense 👍. Any chance you could hunt down a test for this?

src/TwigComponent/src/ComponentRenderer.php Outdated Show resolved Hide resolved
@WebMamba
Copy link
Contributor Author

The failing tests don't look related

@WebMamba WebMamba requested a review from weaverryan September 28, 2023 13:23
@WebMamba WebMamba force-pushed the matheo/fix-twig-component-context-interfer-with-props branch from aeb54b3 to 4e78b02 Compare September 29, 2023 12:29
@weaverryan weaverryan force-pushed the matheo/fix-twig-component-context-interfer-with-props branch from 4e78b02 to 702250d Compare October 2, 2023 17:23
@weaverryan
Copy link
Member

Looks great - thank you Matheo!

@weaverryan weaverryan merged commit 3be6340 into symfony:2.x Oct 2, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weaverryan weaverryan Awaiting requested review from weaverryan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TwigComponent] Anonymous component props and Class backed component properties different behavior
2 participants
@WebMamba @weaverryan