Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding the mapped controller asset as dependency #1154

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

andersonamuller
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
Tickets N/A
License MIT

After updating to the latest changes from AssetMapper component.

Not sure, this is the correct fix, but I got the error that the AssetDependency class was not defined and then changing the line 64 solved for me.

@weaverryan
Copy link
Member

This is the correct change for Symfony 6.4 :). To keep things working with symfony 6.3, let's make this conditional. If the AssetDependency class exists, use the old code. Else use the new code. Can you make that change?

@andersonamuller
Copy link
Contributor Author

This is the correct change for Symfony 6.4 :). To keep things working with symfony 6.3, let's make this conditional. If the AssetDependency class exists, use the old code. Else use the new code. Can you make that change?

@weaverryan Is this what you had in mind? Sorry for the missing tests, don't have much time to dig on that now.

@weaverryan
Copy link
Member

Nailed it! Just an extra, empty line in there now ;).

There is also one test failing on StimulusBundle - it could be unrelated, I just can't tell - that needs to be debugged to see what the underlying problem is.

@weaverryan
Copy link
Member

Thanks Anderson!

@weaverryan weaverryan merged commit afbaeb2 into symfony:2.x Oct 2, 2023
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants