Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow class-string argument in AsLiveComponent static methods #1170

Merged

Conversation

smnandre
Copy link
Member

@smnandre smnandre commented Oct 9, 2023

Q A
Bug fix? no
New feature? ??
License MIT

As done in AsTwigComponent attribute, this PR allow to extract metadata about LiveComponent using their class name.

Test failures unrelated

@weaverryan weaverryan force-pushed the allow-class-string-in-live-attribute branch from ea32f7b to 7266159 Compare October 11, 2023 14:35
@weaverryan
Copy link
Member

Thanks Simon!

@weaverryan weaverryan merged commit 8abb656 into symfony:2.x Oct 11, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants