[Autocomplete] Reset TomSelect when updating controller attributes

[pierredup]

Q	A
Bug fix?	yes
New feature?	no
Issues	Fix #1500
License	MIT

When using remote data for Autocomplete, the mutation observer is not started, so the select cannot be reset when some options change (E.G when limiting the options returned after selecting other options using extra_options from #1322).

Instead, we start the mutation observer when using remote data. When the observer runs and checks if the options have changes, we explicitly set the areOptionsEquivalent to true, since the page will just render an empty select. We also check if any of the data-autocomplete attributes changes and forces a reset (E.G using extra_options, the data-autocomplete-url value can be different when using extra options, so we reset the select when this attribute changes).

This fixes only one of the issues from #1500, I'll investigate the other issues and create separate PRs.

[momocode-de]

I also need this fix. What is the status here?

[github-actions]

📊 Packages dist files size difference

Thanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
Please review the changes and make sure they are expected.

File	Before (Size / Gzip)	After (Size / Gzip)
Autocomplete
controller.d.ts	1.82 kB / 611 B	1.84 kB+2% 📈 / 619 B+1% 📈
controller.js	16.69 kB / 3.96 kB	16.71 kB0% / 3.97 kB0%

[arrabiata-asanz]

thank you to everyone that participated in the bug fix!
@weaverryan Are you merging the branch soon?

[smnandre]

Hey @pierredup, i'm reviving this PR, hoping it's still something you'd like to merge!

How "ready-to-merge" are these changes? Is there anything i need to check in particular?

Thank you!

[pierredup]

Hi @smnandre , there's nothing outstanding on this from my side, so I think it's ready to be merged

[smnandre]

@pierredup great, LGTM!

Could you rebase and add an entry in the src/Autocomplete/CHANGELOG.md (2.23) ?

[smnandre]

Thanks for your patience! :)