[Map] add polyline support

[sblondeau]

Q	A
Bug fix?	no
New feature?	yes
Issues	Fix #...
License	MIT

Add polyline support to Map for Leaflet and GoogleMap (useful e.g. for itinerary drawing)

public function index(): Response
    {
        $map = (new Map('default'))
            ->center(new Point(45.7534031, 4.8295061))
            ->zoom(6)

            ->addPolyline(
                new Polyline(
                    title: 'my title',
                    points: [
                        new Point(48.8566, 2.3522),
                        new Point(45.7640, 4.8357),
                        new Point(43.2965, 5.3698),

                    ]
                )
            )
      ;          
        return $this->render('hom/index.html.twig', [
            'map' => $map,
        ]);;
    }

[github-actions]

📊 Packages dist files size difference

Thanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
Please review the changes and make sure they are expected.

File	Before (Size / Gzip)	After (Size / Gzip)
Map
abstract_map_controller.d.ts	3.31 kB / 821 B	4.45 kB+34% 📈 / 905 B+10% 📈
abstract_map_controller.js	3.23 kB / 843 B	4.31 kB+33% 📈 / 976 B+16% 📈
Map (Bridge Google)
map_controller.d.ts	2.19 kB / 733 B	2.67 kB+22% 📈 / 794 B+8% 📈
map_controller.js	8.7 kB / 1.95 kB	10.38 kB+19% 📈 / 2.14 kB+9% 📈
Map (Bridge Leaflet)
map_controller.d.ts	1.57 kB / 579 B	1.99 kB+27% 📈 / 649 B+12% 📈
map_controller.js	7.2 kB / 2.06 kB	8.8 kB+22% 📈 / 2.24 kB+9% 📈

[WebMamba]

Hey, thanks a lot for this PR @sblondeau! Could you please add more info about this new feature to your PR description? Some screenshots, details and what you trying to achieve! Thannnnnks 😁

[Kocal]

Thanks for the feature, I didn't even know that "polyline" existed :)

I've added some comments that must be resolved if we want to merge your work.

Also, a lot of CI checks are failing, can you take a look please? Thanks!

[sblondeau]

Hello, I tried a lot of things but some tests (js ans php) failed and I do not understand why :(
If someone has some time to investigate...
Thanks :-)

[Kocal]

Hi @sblondeau, where are stuck?

Please ensure to rebase your branch from the latest 2.x quite often, but also try to run some yarn scripts to easy your development:

yarn lint
yarn format
yarn workspaces foreach -Rp --from '{src/Map/assets,src/Map/src/Bridge/Google/assets,src/Map/src/Bridge/Leaflet/assets}' run build
yarn workspaces foreach -Rp --from '{src/Map/assets,src/Map/src/Bridge/Google/assets,src/Map/src/Bridge/Leaflet/assets}' run test

Also, please start to squash your commits, we don't want to see commits 1517fe1 (#2340) like this because it will spam the history for nothing (meaning, harder to blame if necessary).

Thanks!

[sblondeau]

@Kocal thanks for your help with the yarn command (it is not easy to guess them ;-) )
My code works loclaly but I do not understand how to correctly launch tests. I have a failing test with GoogleMap. Sorry if my question sounds stupid but I do not understand how to correctly contribute with this part, should I work in ux map repo or in the bridge repo ? It is frustrating to be stuck so close to the end ;-) Thanks for your help

[Kocal]

@Kocal thanks for your help with the yarn command (it is not easy to guess them ;-) )

Well, in fact

yarn workspaces foreach -Rp --from '{src/Map/assets,src/Map/src/Bridge/Google/assets,src/Map/src/Bridge/Leaflet/assets}' run build

is simply a shortcut to:

(cd src/Map/assets && yarn build)
(cd src/Map/src/Bridge/Google/assets && yarn build)
(cd src/Map/src/Bridge/Leaflet/assets && yarn build)

😛

My code works loclaly but I do not understand how to correctly launch tests. I have a failing test with GoogleMap. Sorry if my question sounds stupid but I do not understand how to correctly contribute with this part, should I work in ux map repo or in the bridge repo ?

Yes! You should work in the UX repository, symfony/ux-* are supposed to be read-only, but it looks like it is not the case.

To run JS tests for Google, you can run cd src/Map/src/Bridge/Google/assets && yarn test.

Keep up the good work! But... I predict you will have a lot of conflicts when #2385 will be merged :P

[Kocal]

Please can you squash all of your commits and rebase on the latest 2.x?
Thanks

[Kocal]

With the merge of #2385 , there are now plenty of conflicts 😅

I'll take it from here :)

[Kocal]

PR squashed and rebased, I've added compatibility with UX Map inside a LiveComponent (I also fixed some things that I've forgot in #2385 😅), and applied some review comments.

[smnandre]

Well, @sblondeau, what a nice first contribution here!

Thank you very much, and i cannot wait to see the next ones :)

[smnandre]

Thanks for your work on this new feature!