Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Map] Add position and missing closing parenthesis #2360

Merged
merged 1 commit into from
Nov 14, 2024
Merged

[Map] Add position and missing closing parenthesis #2360

merged 1 commit into from
Nov 14, 2024

Conversation

tacman
Copy link
Contributor

@tacman tacman commented Nov 10, 2024

so that it works when blindly cutting and pasting.

@tacman
add position and missing closing parenthesis
a432df8 
so that it works when blindly cutting and pasting.
@tacman tacman requested a review from Kocal as a code owner November 10, 2024 10:54
@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Nov 10, 2024
@smnandre smnandre changed the title add position and missing closing parenthesis [Map] Add position and missing closing parenthesis Nov 10, 2024
@smnandre smnandre added docs Improvements or additions to documentation Map labels Nov 10, 2024
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Nov 10, 2024
@javiereguiluz
Copy link
Member

Good catch, thanks Tac.

@javiereguiluz javiereguiluz merged commit 0c71f97 into symfony:2.x Nov 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smnandre smnandre smnandre left review comments

@javiereguiluz javiereguiluz javiereguiluz left review comments

@Kocal Kocal Kocal approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to documentation Map Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tacman @javiereguiluz @smnandre @Kocal @carsonbot