[React] Fix broken Link in docs #2372
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kocal
requested changes
Nov 14, 2024
There was a problem hiding this comment.
Thanks you for opening a pull-request, but the correction is not good.
In fact, what happens here is that https://github.com/symfony/ux/blob/2.x/ux.symfony.com/package.json existed, but it has been recently modified and moved to https://github.com/symfony/ux/blob/2.x/ux.symfony.com/assets/react/build/package.json in a refactoring PR (#2284 and another one IIRC).
Could you please update the link to the good file?
Thanks
carsonbot
added
Status: Needs Work
Kocal
approved these changes
Nov 14, 2024
carsonbot
added
Status: Reviewed
smnandre
added
docs
smnandre
approved these changes
Nov 14, 2024
|
Thank you @xDeSwa. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix broken Link