Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LiveComponent] "Hooks: Handle Component Behavior" spacing issue in docs #2435

Merged
merged 1 commit into from
Dec 11, 2024
Merged

[LiveComponent] "Hooks: Handle Component Behavior" spacing issue in docs #2435

merged 1 commit into from
Dec 11, 2024

Conversation

nehalgajjar
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
Issues Fix #2363
License MIT

[Issue] Fix Line Break / Spacing

image

@carsonbot carsonbot added Bug Bug Fix Status: Needs Review Needs to be reviewed labels Dec 9, 2024
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Dec 9, 2024
smnandre
smnandre requested changes Dec 10, 2024
View reviewed changes
Copy link
Member

@smnandre smnandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, but the original issue is probably due to the lack of empty line between the title and the paragraph.

src/LiveComponent/doc/index.rst Outdated Show resolved Hide resolved
@carsonbot carsonbot added Status: Needs Work Additional work is needed and removed Status: Reviewed Has been reviewed by a maintainer labels Dec 10, 2024
@smnandre smnandre added docs Improvements or additions to documentation LiveComponent and removed Bug Bug Fix labels Dec 10, 2024
@smnandre smnandre changed the title Fix [Live] "Hooks: Handle Component Behavior" spacing issue [LiveComponent] "Hooks: Handle Component Behavior" spacing issue in docs Dec 10, 2024
@smnandre
Copy link
Member

Also, let put this later in the documentation. It's a bit too early right now (all the concepts have not yet been explained that early)

@carsonbot carsonbot added Status: Needs Review Needs to be reviewed and removed Status: Needs Work Additional work is needed labels Dec 10, 2024
@nehalgajjar nehalgajjar requested a review from smnandre December 10, 2024 18:23
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Dec 11, 2024
@smnandre
Copy link
Member

Thank you @nehalgajjar.

@smnandre smnandre merged commit 86d08cb into symfony:2.x Dec 11, 2024
2 checks passed
@nehalgajjar nehalgajjar deleted the patch-1 branch December 11, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kocal Kocal Kocal approved these changes

@smnandre smnandre smnandre approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to documentation LiveComponent Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Live] Docs for PostHydrate, PreDehydrate & PreReRender
4 participants
@nehalgajjar @smnandre @Kocal @carsonbot