[TwigComponent] Minimal support of comment lines #2464
Conversation
Twig introduced the inline comments in twigphp/Twig#4349 This PR add minimal support for it the PreLexer / HTML syntax ```twig <twig:Button # comment bar="bar" /> ``` I'd like some IRL feedbacks on this one :)
Twig introduced the inline comments in twigphp/Twig#4349 This PR add minimal support for it the PreLexer / HTML syntax ```twig <twig:Button # comment bar="bar" /> ``` I'd like some IRL feedbacks on this one :)
There was a problem hiding this comment.
Cool!
I don't have real use-cases from the projets I'm working on, but I believe it will be super-useful (even if I believe some comments can be avoid by using good attribute's name or variable!)
However, introducing a new syntax means that tools manipulating ASTs (like IDEs, Twig-CS-Fixer, maybe TwigStan, and syntax highlighting) will break, right?
|
Not at all, they already are compatible. I'm just following Twig syntax here, not adding anything new. But that means adapting the PreLexer we use to convert HTML Syntax into regular Twig code :) |
|
I mean, for tools that does not use our I've tested with Twig-CS-Fixer and no issues so far, but I think it does not support Twig Component at all. But, for syntax coloration it does not work, and I don't know who/when this new syntax will be added to IDE and other syntax coloration libraries: |
They do, and they integrated inline comments right after Twig release :)
Me neither but... how is this related to this PR ? :) I'm genuinely not sure to get the questions here. Twig syntax changes are generally pretty quickly integrated into PhpStorm Twig integration (or in the Symfony plugin). |
Twig introduced the inline comments in twigphp/Twig#4349
This PR add minimal support for it the PreLexer / HTML syntax
I'd like some IRL feedbacks on this one :)