This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Fixes #5097, fixed extension import to write files with correct id, which was causing project generation to fail #5126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rect id, which was causing project generation to fail
dhirajsb
changed the title
pure-bot
bot
added
the
pr/review-requested
|
@heiko-braun this should fix a ciritical issue in project generation for imported integrations which might be causing #5097. @mmuzikar please test this fix with your sample import zip once it's backported to the 1.6.x branch. |
|
There are unrelated build errors being reported on 1.7.x master branch. So I created another PR #5127 to cherry-pick this fix on 1.6.x. |
oscerd
approved these changes
Apr 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.