Update Settings object

app/Registry.php

@@ -35,7 +35,7 @@ public function __construct(string $settingGroup, string $prefix = '')
 		$this->prefix = $prefix;
 	}
 
-	public function addSettings(SettingItem ...$settings): void
+	public function addSettings(Setting ...$settings): void
 	{
 		foreach ($settings as $key => $setting) {
 			$this->settings[$this->getPrefixedName($setting)] = $setting;

app/Settings.php

@@ -9,6 +9,8 @@
 use Syntatis\Utils\Val;
 use Traversable;
 
+use function is_array;
+
 /** @phpstan-implements IteratorAggregate<string,Registry> */
 class Settings implements IteratorAggregate
 {
@@ -48,11 +50,13 @@ public function getAll(): array
 		$settings = [];
 
 		foreach ($this->registries as $group => $registry) {
-			if (! ($registry instanceof Registry)) {
+			$registeredSettings = $registry->getRegisteredSettings();
+
+			if (! is_array($registeredSettings) || Val::isBlank($registeredSettings)) {
 				continue;
 			}
 
-			$settings[$group] = $registry->getRegisteredSettings();
+			$settings[$group] = $registeredSettings;
 		}
 
 		return $settings;

tests/app/SettingsTest.php

@@ -108,14 +108,15 @@ public function testGetAfterRegisteredWithPrefix(): void
 
 	public function testGetAllBeforeRegistered(): void
 	{
+		$group1 = new Registry('group1');
+		$group1->addSettings(new Setting('say'), new Setting('hello'));
+
+		$group2 = new Registry('group2');
+		$group2->addSettings(new Setting('world'));
+
 		$settings = new Settings([
-			'group1' => (new Registry('group1'))->addSettings(
-				new Setting('say'),
-				new Setting('hello'),
-			),
-			'group2' => (new Registry('group2'))->addSettings(
-				new Setting('world'),
-			),
+			'group1' => $group1,
+			'group2' => $group2,
 		]);
 
 		$this->assertSame([], $settings->getAll());