Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(agent): add permissions for reporting Kubernetes events to K8s #1298

Merged
merged 6 commits into from
Oct 30, 2023
Merged

feature(agent): add permissions for reporting Kubernetes events to K8s #1298

merged 6 commits into from
Oct 30, 2023

Conversation

thesw4rm
Copy link
Contributor

@thesw4rm thesw4rm commented Aug 10, 2023 •
edited by mavimo
Loading

What this PR does / why we need it:

Added create and patch verbs for events to report container actions to Kubernetes.

Checklist

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Check GithubAction checks (like lint) to avoid merge-check stoppers

@thesw4rm thesw4rm requested a review from a team as a code owner August 10, 2023 14:07
@github-actions
Copy link
Contributor

Hi @thesw4rm. Thanks for your PR.

After inspecting your changes someone with write access to this repo needs
to approve and run the workflow with the following slash_command.

NOTE: the workflow triggered this way will only report the final status to this PR,
in order to check the logs please go to the Actions tab and look for approve-test-run-command.

  • /approve-test-run sha=<short commit sha to test>: Run helm chart linting and testing workflow

@github-actions github-actions bot added the no-tests Chart templates modified without test changes label Aug 10, 2023
@thesw4rm thesw4rm changed the title agent: SSPROD-7700 permissions feature(agent): SSPROD-7700 permissions for Kubernetes events Aug 10, 2023
@thesw4rm thesw4rm changed the title feature(agent): SSPROD-7700 permissions for Kubernetes events feature(agent): add permissions for Kubernetes events Aug 10, 2023
@thesw4rm thesw4rm changed the title feature(agent): add permissions for Kubernetes events feature(agent): add permissions for reporting Kubernetes events Aug 10, 2023
@mavimo
Copy link
Contributor

mavimo commented Oct 5, 2023

/approve-test-run sha=b4ef667

@mavimo mavimo changed the title feature(agent): add permissions for reporting Kubernetes events feature(agent): add permissions for reporting Kubernetes events to K8s Oct 5, 2023
@github-actions github-actions bot removed the no-tests Chart templates modified without test changes label Oct 5, 2023
@mavimo
Copy link
Contributor

mavimo commented Oct 13, 2023

/approve-test-run sha=b18be93

@mavimo mavimo force-pushed the SSPROD-7700 branch 2 times, most recently from 0aed6d0 to c4d083b Compare October 30, 2023 19:16
@mavimo mavimo enabled auto-merge (squash) October 30, 2023 19:44
@mavimo mavimo merged commit 1fca530 into sysdiglabs:master Oct 30, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrishi lrishi lrishi approved these changes

@mavimo mavimo mavimo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thesw4rm @mavimo @lrishi