-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pin google provider and terraform versions due to breaking changes #151
Conversation
also need to update examples. please followup to add a warning on the onboarding/doc for the fixed TF version < 1.6 |
Do the examples need to be updated? Don't they inherit the constraints from the modules?
Do you mean in the UI or the sysdig docs? (or both)? Going to merge this as current installs are broken, will follow up with additional PRs to address these comments |
version restrictions are per module, and examples don't seem to inherit it upwards 🤔 have not checked but maybe there is some way to avoid that maintenance. i already addressed that on the PR! yeah, i would update requirements on this module everywhere it appears (onboarding and docs) remember to release the module! |
Thanks @wideawakening, I missed that you already updated the other version files. I will take a pass of the docs and make sure to update them as needed, and yes I already released these changes =) |
Pin version of the GCP provider due to breaking changes introduced in 5.0.0
Pin version of terraform used in cloudconnector module due to breaking changes in 1.6.0