Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin google provider and terraform versions due to breaking changes #151

Merged
merged 7 commits into from
Oct 12, 2023

Conversation

nkraemer-sysdig
Copy link
Contributor

Pin version of the GCP provider due to breaking changes introduced in 5.0.0
Pin version of terraform used in cloudconnector module due to breaking changes in 1.6.0

@nkraemer-sysdig nkraemer-sysdig requested review from haresh-suresh and a team as code owners October 11, 2023 23:33
@wideawakening
Copy link
Contributor

wideawakening commented Oct 12, 2023

also need to update examples.
min/max terraform version is not working as expected or i'm not able to find the proper setup.
gonna hardcode tf install version for the moment

please followup to add a warning on the onboarding/doc for the fixed TF version < 1.6

@nkraemer-sysdig
Copy link
Contributor Author

nkraemer-sysdig commented Oct 12, 2023

also need to update examples.

Do the examples need to be updated? Don't they inherit the constraints from the modules?

please followup to add a warning on the onboarding/doc for the fixed TF version < 1.6

Do you mean in the UI or the sysdig docs? (or both)?

Going to merge this as current installs are broken, will follow up with additional PRs to address these comments

@nkraemer-sysdig nkraemer-sysdig enabled auto-merge (squash) October 12, 2023 16:02
@nkraemer-sysdig nkraemer-sysdig merged commit 21d0350 into master Oct 12, 2023
8 checks passed
@nkraemer-sysdig nkraemer-sysdig deleted the fix/pin-versions branch October 12, 2023 16:44
@wideawakening wideawakening changed the title Pin google provider and terraform versions due to breaking changes fix: pin google provider and terraform versions due to breaking changes Oct 13, 2023
@wideawakening
Copy link
Contributor

wideawakening commented Oct 13, 2023

version restrictions are per module, and examples don't seem to inherit it upwards 🤔 have not checked but maybe there is some way to avoid that maintenance. i already addressed that on the PR!

yeah, i would update requirements on this module everywhere it appears (onboarding and docs)

remember to release the module!

@nkraemer-sysdig
Copy link
Contributor Author

Thanks @wideawakening, I missed that you already updated the other version files. I will take a pass of the docs and make sure to update them as needed, and yes I already released these changes =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants