Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate cloud-bench #155

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Deprecate cloud-bench #155

merged 3 commits into from
Nov 12, 2024

Conversation

nkraemer-sysdig
Copy link
Contributor

The cloud-bench submodule has been deprecated, and replaced with https://github.com/sysdiglabs/terraform-google-secure

This PR removes outdated information relating to the cloud-bench submodule.

@nkraemer-sysdig nkraemer-sysdig requested review from haresh-suresh and a team as code owners November 5, 2024 23:45
haresh-suresh
haresh-suresh previously approved these changes Nov 11, 2024
Copy link
Contributor

@haresh-suresh haresh-suresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haresh-suresh
Copy link
Contributor

It is complaining about the version updates in the README's though : https://github.com/sysdiglabs/terraform-google-secure-for-cloud/actions/runs/11694407364/job/32568250505?pr=155

ravinadhruve10
ravinadhruve10 previously approved these changes Nov 11, 2024
Copy link

@ravinadhruve10 ravinadhruve10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nkraemer-sysdig nkraemer-sysdig merged commit c36bb00 into master Nov 12, 2024
8 checks passed
@nkraemer-sysdig nkraemer-sysdig deleted the deprecate-cloud-bench branch November 12, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants