Add decoder for RVV instructions #501
Conversation
There was a problem hiding this comment.
Benchmarks
| Benchmark suite | Current: f092a89 | Previous: 9225e3b | Ratio |
|---|---|---|---|
Dhrystone |
1473 Average DMIPS over 10 runs |
1550 Average DMIPS over 10 runs |
1.05 |
Coremark |
1416.118 Average iterations/sec over 10 runs |
1409.498 Average iterations/sec over 10 runs |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
howjmay
force-pushed
the
rvv
branch
2 times, most recently
from
7de4a2a to
11ea214
Compare
howjmay
force-pushed
the
rvv
branch
5 times, most recently
from
2dcaaf6 to
73db290
Compare
|
How can you test the RVV instructions? |
|
A test set own by chipsalliance is here. https://github.com/chipsalliance/riscv-vector-tests/tree/main I think we can test instructions' behavior with this repo. However, testing decoder is harder. I think I will Spike the verify the behavior, or generating the test cases |
| @@ -370,6 +370,9 @@ static bool has_loops = false; | |||
| } | |||
|
|
|||
| #include "rv32_template.c" | |||
| #if RV32_HAS(EXT_RVV) | |||
| #include "rv32_rvv_template.c" | |||
| /* | ||
| * This file is auto-generated by running 'make' in | ||
| * https://github.com/riscv/riscv-opcodes (9226b0d) | ||
| * and it is temporarily used by RVV only | ||
| */ |
There was a problem hiding this comment.
Related: #103
Do you think it makes sense to replace the existing hand-written RISC-V instruction decoder with the generated one?
There was a problem hiding this comment.
I think the current one is good for education, especially the comments are valuable.
However I think having a table to clearly store the instructions in human-readable form is good for the future development.
There was a problem hiding this comment.
But this encoding.h is only a temporary header file for me to decode rvv instructions.
relate to #504