Refactor snapshot updating/checking scripts #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I create a mkconfig for current session variable storage? For example, when I changed to riscv, until next time I |
Feel free to consolidate! Check #44 |
ChAoSUnItY
force-pushed
the
fix/rv32-snapshot
branch
3 times, most recently
from
2652237 to
53e2042
Compare
jserv
reviewed
Dec 7, 2024
jserv
reviewed
Dec 7, 2024
ChAoSUnItY
force-pushed
the
fix/rv32-snapshot
branch
from
53e2042 to
8fc46c5
Compare
|
I would like to work on package prerequisites validation in another PR after the this one is merged. |
jserv
reviewed
Dec 8, 2024
jserv
reviewed
Dec 8, 2024
ChAoSUnItY
force-pushed
the
fix/rv32-snapshot
branch
from
8fc46c5 to
b595e34
Compare
jserv
reviewed
Dec 8, 2024
jserv
reviewed
Dec 8, 2024
ChAoSUnItY
force-pushed
the
fix/rv32-snapshot
branch
from
b595e34 to
1e02b7a
Compare
jserv
reviewed
Dec 8, 2024
jserv
reviewed
Dec 8, 2024
ChAoSUnItY
force-pushed
the
fix/rv32-snapshot
branch
from
1e02b7a to
7d9e2b2
Compare
jserv
reviewed
Dec 8, 2024
jserv
reviewed
Dec 8, 2024
jserv
reviewed
Dec 8, 2024
ChAoSUnItY
force-pushed
the
fix/rv32-snapshot
branch
from
7d9e2b2 to
a2cfa70
Compare
jserv
reviewed
Dec 8, 2024
jserv
reviewed
Dec 8, 2024
jserv
reviewed
Dec 8, 2024
ChAoSUnItY
force-pushed
the
fix/rv32-snapshot
branch
from
a2cfa70 to
ef7d273
Compare
jserv
requested changes
Dec 15, 2024
- Adds .session.mk generation for consistent makefile execution behavior. - Refine document about snapshot test Co-authored-by: Meng-Hung Chen <[email protected]>
ChAoSUnItY
force-pushed
the
fix/rv32-snapshot
branch
from
ef7d273 to
f2050f3
Compare
|
Thank @ChAoSUnItY for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously in #171, I had encountered an snapshot checking issue, which is snapshot only contains arm32 backend but rv32. In order to resolve this, I have added few more rules to update/check snapshots:
make update-snapshots/make check-snapshotsUpdates/Checks all backends' snapshots.
make update-snapshot/make check-snapshotsUpdates/Checks current backend's snapshots.
Additionally I've separated arm and riscv backend CI into different matrix, to better observe which backend is running into failure.
Breaking changes for snapshots scripts
Now directly using snapshots scripts is unrecommended, instead, uses the above mentioned make rules to update/check snapshots.